The toddler was written to remove all users from all packager groups if they cease to be (or have never been) in IPA packager group, which is the source of truth.
All distgit groups are considered packager groups, the consensus was that the toddler should attempt to remove users who are members of any distgit group: https://pagure.io/fedora-infra/toddlers/issue/190#comment-917696

I see @amedvede as member of packager group in IPA: https://accounts.fedoraproject.org/user/amedvede/ so the toddler should not try to remove him (unless he was added to the packager group recently to avoid being removed by the toddler)

@darknao is not a member of packager group, thus according to the toddler specs he is a candidate to be removed.

Being a distdit group member AND NOT an IPA packager is a situation which the cleaning_packager_group toddler was written to solve.

I can see two options here:
1. We add darknao and amedvede to IPA packager group
2. We implement an exception to the toddler, that checks presence of a candidate to be removed in cvsadmin and sysadmin-main group. If they are members, they will not be removed from any distgit groups nor their IPA mirrors.

I think there's some confusion about what I was meaning by 'dist-git' group.

If you look at:

https://src.fedoraproject.org/groups

You nowhere see sysadmin-main or cvsadmin.

Those groups are allowed access to that host in ipa, but they are not groups that are known to the pagure instance itself.

I see @amedvede as member of packager group in IPA: https://accounts.fedoraproject.org/user/amedvede/ so the toddler should not try to remove him (unless he was added to the packager group recently to avoid being removed by the toddler)

Yes, I added him when I re-added him to the other groups.

@darknao is not a member of packager group, thus according to the toddler specs he is a candidate to be removed.
I can see two options here:
1. We add darknao and amedvede to IPA packager group

yeah, I can re-add darknao now.

1. We implement an exception to the toddler, that checks presence of a candidate to be removed in cvsadmin and sysadmin-main group. If they are members, they will not be removed from any distgit groups nor their IPA mirrors.

Is there any way to only consider groups that are listed at https://src.fedoraproject.org/groups ?
If we could do that, then the problem goes away because they are not in any of those groups...

Oh, but as @lenkaseg pointed out to me, I am blind or something because those groups are there. ;(

So, thats no help.

I worry about having to add packager to anyone added to those groups, if we forget they will be removed later and we will have to figure it out again. ;(

So, perhaps we should see how hard it would be to add exception groups...

I will addignored groups (sysadmin-main and cvsadmin) and the toddler will not remove the users from those (both on IPA and distgit side).

This should work! https://pagure.io/fork/lenkaseg/fedora-infra/toddlers/c/29d405134f81ac0ca1550d1cafd8d4e8d59c4f32

Awesome. Thanks for the quick fix!

Anything else to do here? Or shall we close this as done now?

I guess we could. We can reopen if the solution is not sufficient.

ok, thanks!