Describe what you would like us to do:

Please filter the messages that fm-koji sends to #koji as before.
This appears to be a regression of the fix from #7086
Currently the channel is getting pagure messages for unrelated projects.

It's not clear to me why this regression has happened. It doesn't look like the filter rules have changed.

https://pagure.io/fedora-infra/ansible/blob/main/f/roles/fedmsg/irc/templates/ircbot.py#_558

When do you need this to be done by? (YYYY/MM/DD)

2021/06/11

kevin commented 3 years ago

Nothing has changed here (except the irc network)

Can you attach a list of these messages so we know what it's matching ?

Note that the match is pretty simple and may be giving you any messages with 'koji' in them somewhere.

Metadata Update from @mohanboddu:
- Issue priority set to: Waiting on Assignee (was: Needs Review)
- Issue tagged with: low-gain, low-trouble, ops

3 years ago

Metadata Update from @ryanlerch:
- Issue priority set to: Waiting on Reporter (was: Waiting on Assignee)

3 years ago

ryanlerch commented 3 years ago

sat in #koji for a bit, and here is a message that got through. Looks like it might be matching on the koji URL in the flag

https://apps.fedoraproject.org/datagrepper/id?id=2021-542714a3-03c1-41c4-b8e4-4f0fac2b75b0&is_raw=true&size=extra-large

{
  "username": "amqp-bridge", 
  "source_name": "datanommer", 
  "certificate": "LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUUyakNDQkVPZ0F3SUJBZ0lDQXBzd0RRWUpL\nb1pJaHZjTkFRRUxCUUF3Z2FBeEN6QUpCZ05WQkFZVEFsVlQKTVFzd0NRWURWUVFJRXdKT1F6RVFN\nQTRHQTFVRUJ4TUhVbUZzWldsbmFERVhNQlVHQTFVRUNoTU9SbVZrYjNKaApJRkJ5YjJwbFkzUXhE\nekFOQmdOVkJBc1RCbVpsWkcxelp6RVBNQTBHQTFVRUF4TUdabVZrYlhObk1ROHdEUVlEClZRUXBF\nd1ptWldSdGMyY3hKakFrQmdrcWhraUc5dzBCQ1FFV0YyRmtiV2x1UUdabFpHOXlZWEJ5YjJwbFkz\nUXUKYjNKbk1CNFhEVEU0TURreU5qSXpNalV3T0ZvWERUSTRNRGt5TXpJek1qVXdPRm93Z2VReEN6\nQUpCZ05WQkFZVApBbFZUTVFzd0NRWURWUVFJRXdKT1F6RVFNQTRHQTFVRUJ4TUhVbUZzWldsbmFE\nRVhNQlVHQTFVRUNoTU9SbVZrCmIzSmhJRkJ5YjJwbFkzUXhEekFOQmdOVkJBc1RCbVpsWkcxelp6\nRXhNQzhHQTFVRUF4TW9abVZrYlhObkxXMXAKWjNKaGRHbHZiaTEwYjI5c2N5NW1aV1J2Y21Gd2Nt\nOXFaV04wTG05eVp6RXhNQzhHQTFVRUtSTW9abVZrYlhObgpMVzFwWjNKaGRHbHZiaTEwYjI5c2N5\nNW1aV1J2Y21Gd2NtOXFaV04wTG05eVp6RW1NQ1FHQ1NxR1NJYjNEUUVKCkFSWVhZV1J0YVc1QVpt\nVmtiM0poY0hKdmFtVmpkQzV2Y21jd2dnRWlNQTBHQ1NxR1NJYjNEUUVCQVFVQUE0SUIKRHdBd2dn\nRUtBb0lCQVFEUm4xd1E1UVZwN2JCdUpFUjlNOUkwZ2o0WHB0NTlFZDdnU1p2RVQvcSsrUVNFb0x2\nWApkb0tnOTdkWXhZK2FPdll1TDAzc1lOdjZEcmJLZVM2blk5V1dwKytoZ1hUMXBEaFY3QmRxeitt\nNFoxbDhsYjFHCi9mZHAwd1FON0RMVndDclYyTmNSajZ6b2J0NHV2Z0JYaWtVUWhRNjl5V2E2VE9D\nTis5OWEwUUtjTUJzNENuNTAKc2pmUTNGQUNsV1B3NUhkNkNPMHJWenhPODRROGc0bEpCcTRubHY0\nc0xRVmZoZTNoZWMzTEFObUt2RGNSc3JpbgpDUXFGdFF5MVNmR0pHWnE4RkEyUDhkckVCd1BqdnZx\nMTJ4MHJucEJjdVM5bXlLQmhOYVE3eSs5bE9GTXJSZFBrCmRaUXY0eGdSU0FzZGJQRDlyeXYrTE1n\nS1YvVnVTdm11RzF0eEFnTUJBQUdqZ2dGWE1JSUJVekFKQmdOVkhSTUUKQWpBQU1DMEdDV0NHU0FH\nRytFSUJEUVFnRmg1RllYTjVMVkpUUVNCSFpXNWxjbUYwWldRZ1EyVnlkR2xtYVdOaApkR1V3SFFZ\nRFZSME9CQllFRkM0anZCbmhFSnRDTkxHaTg5UHgreU41K1VNa01JSFZCZ05WSFNNRWdjMHdnY3FB\nCkZHdEFXdmtTQ0lsWjUxbmxCZlVDSFFwT2Z4UUFvWUdtcElHak1JR2dNUXN3Q1FZRFZRUUdFd0pW\nVXpFTE1Ba0cKQTFVRUNCTUNUa014RURBT0JnTlZCQWNUQjFKaGJHVnBaMmd4RnpBVkJnTlZCQW9U\nRGtabFpHOXlZU0JRY205cQpaV04wTVE4d0RRWURWUVFMRXdabVpXUnRjMmN4RHpBTkJnTlZCQU1U\nQm1abFpHMXpaekVQTUEwR0ExVUVLUk1HClptVmtiWE5uTVNZd0pBWUpLb1pJaHZjTkFRa0JGaGRo\nWkcxcGJrQm1aV1J2Y21Gd2NtOXFaV04wTG05eVo0SUoKQU9OUUhrZFBGeDVGTUJNR0ExVWRKUVFN\nTUFvR0NDc0dBUVVGQndNQ01Bc0dBMVVkRHdRRUF3SUhnREFOQmdrcQpoa2lHOXcwQkFRc0ZBQU9C\nZ1FBQnFBcDQzd3lUbk5XUUJYODUzSEVEUEpDTTM4aVJTdlV3dzFCejd4MmFpSWpuCkVPTWZ1djhB\nTEV2Z2JXeDhSc0RBNTluRkNXS1FJRWdGeEFBcUFMUFJwYWF3dFRUcnN1VlQ3bFhlSEhrU21VblEK\ncEdKSFd1elU2OUZibFdaWkpDTVQzUTRVYWNUa0VHNE1XMFFqOWp1aFNpM2lHOHZXVXZlMTEzUTNL\nMDhmVHc9PQotLS0tLUVORCBDRVJUSUZJQ0FURS0tLS0tCg==\n", 
  "i": 2758666, 
  "timestamp": 1623798365.0, 
  "msg_id": "2021-542714a3-03c1-41c4-b8e4-4f0fac2b75b0", 
  "crypto": "x509", 
  "topic": "org.fedoraproject.prod.pagure.commit.flag.added", 
  "headers": {}, 
  "signature": "xjoFCeJKAcwWAHJj35GfVbGWIXIp/eYE9pbV/uEBguKlAonBWjW/4gEwWkAd+Qms/fddZm3CzmPK\nCZ5OEdB+s7RnFT+HkuK/vkaQT7acskyCjdz3+PkoZnVmOIACUCWuZTV/gRoKKKJZz2Yd9m9nsA4g\n8q6BrobzGxDowljGeBrQ+iapwGOLTMgwZsKspMoKZ3ndG8F6pdbqXVP4uIRpzfFUTgzpr2Santjl\nwXhxfWKPz0/4c6wL9J8674uV0OJpQNXgb3F09OZECJJvV1yquZiUOYEHeD2h5JnbsOnauBfw+DSR\nI7Ig2kaC0heKDLGYP5wbZGOWIfojan8ql+tywQ==\n", 
  "source_version": "0.9.0", 
  "msg": {
    "repo": {
      "custom_keys": [], 
      "description": "Open Source IRC server", 
      "parent": null, 
      "date_modified": "1604941235", 
      "access_users": {
        "admin": [], 
        "collaborator": [], 
        "ticket": [], 
        "owner": [
          "robert"
        ], 
        "commit": []
      }, 
      "namespace": "rpms", 
      "priorities": {}, 
      "full_url": "https://src.fedoraproject.org/rpms/unrealircd", 
      "access_groups": {
        "admin": [], 
        "collaborator": [], 
        "ticket": [], 
        "commit": []
      }, 
      "milestones": {}, 
      "user": {
        "fullname": "Robert Scheck", 
        "url_path": "user/robert", 
        "full_url": "https://src.fedoraproject.org/user/robert", 
        "name": "robert"
      }, 
      "id": 46752, 
      "date_created": "1604941230", 
      "fullname": "rpms/unrealircd", 
      "url_path": "rpms/unrealircd", 
      "close_status": [], 
      "tags": [
        ""
      ], 
      "name": "unrealircd"
    }, 
    "flag": {
      "comment": "Built as unrealircd-5.2.0-1.el7", 
      "status": "success", 
      "date_updated": "1623798365", 
      "percent": null, 
      "username": "Build completed", 
      "url": "https://koji.fedoraproject.org/koji/taskinfo?taskID=70196775", 
      "commit_hash": "84e5e7a3649fa81848d1017271955c222f202c94", 
      "date_created": "1623798365", 
      "user": {
        "fullname": "Pierre-YvesChibon", 
        "url_path": "user/pingou", 
        "full_url": "https://src.fedoraproject.org/user/pingou", 
        "name": "pingou"
      }
    }, 
    "agent": "pingou"
  }
}

ryanlerch commented 3 years ago

I think changing the filters for this to the following might work -- i'll open a PR in ansible now

            filters=dict(
                topic=[
                    '^((?!(pagure)).)*$',
                ],
                body=['^((?!(pagure.io\/koji)).)*$',
                      "u'fullname': u'koji'"],
            ),
        ),

ryanlerch commented 3 years ago

My assumption here is you only want messages when things happen to the koji project on pagure.io right?

ryanlerch commented 3 years ago

Here is the PR for my suggested change:

https://pagure.io/fedora-infra/ansible/pull-request/643

Metadata Update from @ryanlerch:
- Issue assigned to ryanlerch

3 years ago

kevin commented 3 years ago

I merged the pr and restarted the service.

Shall we wait a while or just close this and re-open it if it's still an issue?

ryanlerch commented 3 years ago

It looks like the spamming has stopped -- but not sure if any notifications are coming though now...