#10852 flatpak-indexer not picking up new builds
Closed: Fixed 2 years ago by kalev. Opened 2 years ago by kalev.

Looks like flatpak-indexer has fallen over again in some way and new builds (e.g. https://bodhi.fedoraproject.org/updates/FEDORA-FLATPAK-2022-2317a47dbe) are getting indexed.


Metadata Update from @phsmoura:
- Issue priority set to: Waiting on Assignee (was: Needs Review)
- Issue tagged with: medium-gain, medium-trouble, ops

2 years ago

So, the problem seems to be:

2022-08-15 19:36:30,557:INFO:flatpak_indexer.bodhi_query:Querying Bodhi with params: {'rows_per_page': 100, 'exclude_archived': 1, 'page': 1}
2022-08-15 19:36:30,587:INFO:flatpak_indexer.bodhi_query:Querying Bodhi with params: {'rows_per_page': 10, 'releases': ['F35F', 'F36F', 'F38F'], 'submitted_since': '2022-08-09T17:59:20.624324+00:00', 'page': 1}
2022-08-15 19:36:30,609:ERROR:flatpak_indexer.cli:Failed to update data sources
Traceback (most recent call last):
  File "/opt/app-root/lib64/python3.9/site-packages/flatpak_indexer/cli.py", line 61, in daemon
    updater.update(registry_data)
  File "/opt/app-root/lib64/python3.9/site-packages/flatpak_indexer/datasource/fedora/updater.py", line 89, in update
    refresh_all_updates(session, content_type='flatpak')
  File "/opt/app-root/lib64/python3.9/site-packages/flatpak_indexer/bodhi_query.py", line 291, in refresh_all_updates
    session.redis_client.transaction(
  File "/opt/app-root/lib64/python3.9/site-packages/redis/client.py", line 1091, in transaction
    func_value = func(pipe)
  File "/opt/app-root/lib64/python3.9/site-packages/flatpak_indexer/bodhi_query.py", line 277, in _refresh_all_updates
    _query_updates(session, requests_session,
  File "/opt/app-root/lib64/python3.9/site-packages/flatpak_indexer/bodhi_query.py", line 191, in _query_updates
    _run_query(requests_session,
  File "/opt/app-root/lib64/python3.9/site-packages/flatpak_indexer/bodhi_query.py", line 107, in _run_query
    response.raise_for_status()
  File "/opt/app-root/lib64/python3.9/site-packages/requests/models.py", line 1021, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://bodhi.fedoraproject.org/updates/?rows_per_page=10&releases=F35F&releases=F36F&releases=F38F&submitted_since=2022-08-09T17%3A59%3A20.624324%2B00%3A00&page=1

and indeed there's no F38F in bodhi. There is a F37F tho... so, should this be using F37F or should bodhi have a F38F now? or both?
:)

It should be using F37F. We don't do rawhide flatpak builds and F38F is supposed to be only be created after F38 branching (in 6 months).

I looked at flatpak-indexer code and it queries releases dynamically from Bodhi. The problem seems to be that in Bodhi F37 is marked as 'Branch: rawhide', and F38 is marked as 'Branch: f38'. It should be the other way around so that F38 is rawhide.

Compare the Branch properties in:
https://bodhi.fedoraproject.org/releases/F38
https://bodhi.fedoraproject.org/releases/F37

ok, fixed those and rolled out another flatpak-indexer. It seems to be processing away.

If all looks good, feel free to close.

Awesome, thank you! Out of curiosity, where was the fix to Bodhi? Not in ansible, it seems, because I don't see any new commits there?

Yeah, just bodhi cli...

bodhi releases edit --name F37 --branch f37
bodhi releases edit --name F38 --branch rawhide

Ahh, I see. Thanks!

I'll confirm that the index works right tomorrow morning since it takes a while to process.

OK, new builds are in the index now and everything seems to be working correctly. Thanks again!

Metadata Update from @kalev:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

2 years ago

Log in to comment on this ticket.

Metadata
Boards 1
ops Status: Backlog