Some Fedora CI users are not provenpackagers, but they contribute tests and would like to be able to restart Fedora CI from Bodhi.
provenpackagers
We would like to propose the creation of a new Fedora user group called fedora-ci-users which we can manage together with @adamwill @msrb and @mvadkert (me) to onboard such users to this use case.
fedora-ci-users
When you have time :) but we have some unhappy users for Fedora CI due to this.
This seems sensible to me, the idea is to have a group of people who can use the 'restart tests' button on Bodhi without getting provenpackager privileges. We don't want to let just anyone hit that button all the time but it does make sense to have some folks with responsibilities in CI who can do it when appropriate.
i am able to create the group in Fedora Accounts, but is there anything additional we need to do on the bodhi side to get what you are after working?
Metadata Update from @ryanlerch: - Issue assigned to ryanlerch
yeah, there would need to be change in bodhi too, but we were gonna file a bodhi ticket for that. I didn't look at exactly what would be needed yet, probably just a tweak to some list(s) of who gets to see the button and use the API endpoint...
hmm, looking at the bodhi side briefly, it might be a bit more complicated. it seems to be quite tied to update editing privileges.
do you want the group created still? or loop back to this when the bodhi feature is ready?
either way, adding the group is a 30sec task, so <shurgs>
it might be a good idea to wait and see if we can figure out the bodhi side, I guess...
Metadata Update from @phsmoura: - Issue priority set to: Waiting on Assignee (was: Needs Review) - Issue tagged with: low-gain, low-trouble, ops
On bodhi side I opened https://github.com/fedora-infra/bodhi/issues/5448 to track the RFE, but I haven't got any time to look at that yet.
Bodhi PR: https://github.com/fedora-infra/bodhi/pull/5454
I've deployed that into staging bodhi, I don't know if there's a way to test it since staging functionality is limited.
awesome, thanks. sorry, I am buried under piles of fire ATM, but will look at moving this forward as soon as I can if nobody else does.
Whats the status here? if we want to deply to prod before freeze we need to do it today or tomorrow morning. ;)
I also want to get the flatpaks f39 fix in... so we could do this at the same time perhaps?
Whats the status here? if we want to deply to prod before freeze we need to do it today or tomorrow morning. ;) I also want to get the flatpaks f39 fix in... so we could do this at the same time perhaps?
The bodhi bits are merged in the main branch. However I'm not sure this change can be backported to the 7.x branch because there were some changes in backend authentication in devel. Also, I cannot draft a release before final freeze (aka right now). It might be necessary to wait for the next major release after F39 release.
About the flatpaks fixes, I can draft a minor release in the next days and ask a freeze exception.
CC @mcermak
thanks for working on this, looking forward once this gets deployed!
Would it be possible to implement this not only for tests re-trigger, but also for tests waiving please? Or does waiving seem like a material for a separate conversation? I guess the implementation might be very similar.
Yes, the Bodhi change will allow both.
Whats the status here? waiting for the next release?
yeah, I believe so. maybe we need to poke the Bodhi maintainer to do one now we're in a quiet phase?
I have been facing with some unexpected Bodhi test failures and didn't have much time to investigate them since it's been a crazy week... I think I can prepare a new release in a couple of weeks, but if anyone else wants to do that before, I certainly won't object ;-) The new release will involve a database schema change, so it may be useful to deploy it in stg first.
I would also kinda like to do https://pagure.io/fedora-ci/general/issue/436 for the next Bodhi release, hopefully I can write that next week...
am i ok to make the new group?
am i ok to make the new group? fedora-ci-users
Yes, I think. That group name will be the default in Bodhi config. The feature can already be tested in staging, while waiting for deployment in prod.
group is created:
https://accounts.fedoraproject.org/group/fedora-ci-users/
going to close this one now, as this is really all that was asked in the ticket -- happy to reopen if you want to use this ticket to track the other items...
Metadata Update from @ryanlerch: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Bodhi 8.0 is now deployed in prod, so members of fedora-ci-users should now be able to trigger/waive tests on all updates. If something doesn't work as expected, don't hesitate to report to upstream Bodhi bugtracker.
Thank you for this, this will be a great improvement!
Log in to comment on this ticket.