#12391 fix handlers from/for ansible-lint
Closed: Fixed a month ago by kevin. Opened a month ago by kevin.

ansible-lint wants names to start with a capital letter ie, [A-Z] (I am not sure why, but I don't much care either way).

Recently @ryanlerch changed some handlers to do this. Unfortunately, if you change a handler, you have to also change everywhere it's called, because the way ansible knows what handler you want to notify is by it's name. ;(

So right now we have kinda a mix.

It would be nice to change all handlers and everywhere they are notified to work.

There are top level handlers and a bunch of roles that have their own:

./handlers
./roles/abrt/faf-post/handlers
./roles/abrt/faf-pre/handlers
./roles/abrt/faf/handlers
./roles/abrt/retrace-post/handlers
./roles/abrt/retrace/handlers
./roles/ansible-osbuild-worker/handlers
./roles/apache/handlers
./roles/apps-fp-o/handlers
./roles/base/handlers
./roles/basessh/handlers
./roles/btrfs/handlers
./roles/check-compose/handlers
./roles/copr/backend/handlers
./roles/copr/base/handlers
./roles/copr/dist_git/handlers
./roles/copr/frontend/handlers
./roles/distgit/pagure/handlers
./roles/dnf-automatic/handlers
./roles/docker-distribution/handlers
./roles/fedmsg/hub/handlers
./roles/fedora_nightlies/handlers
./roles/haproxy/handlers
./roles/ipa/client/handlers
./roles/ipa/server/handlers
./roles/ipsilon/handlers
./roles/keepalived/handlers
./roles/koji_builder/handlers
./roles/kojipkgs/handlers
./roles/mailman3/handlers
./roles/mariadb_server/handlers
./roles/mote/handlers
./roles/nagios_client/handlers
./roles/nagios_server/handlers
./roles/openqa/dispatcher/handlers
./roles/openqa/worker/handlers
./roles/pagure/handlers
./roles/postgresql_server/handlers
./roles/rabbit/queue/handlers
./roles/relvalconsumer/handlers
./roles/robosignatory/handlers
./roles/rsyncd/handlers
./roles/spamassassin/handlers
./roles/varnish/handlers
./roles/zabbix/zabbix_agent/handlers

But they can be called from anywhere.


Metadata Update from @phsmoura:
- Issue priority set to: Waiting on Assignee (was: Needs Review)
- Issue tagged with: medium-gain, medium-trouble, ops

a month ago

Metadata Update from @zlopez:
- Issue assigned to zlopez

a month ago

I spend few hours on this, but I think I addressed all the handlers in https://pagure.io/fedora-infra/ansible/pull-request/2461

I hoped I didn't missed anything.

Log in to comment on this ticket.

Metadata
Boards 1
ops Status: Backlog
Related Pull Requests
  • #2461 Merged a month ago