ok. I think these redirects are in place now.

Can you check them over and make sure I didn't miss anything?

Thanks.

:u5408:

The redirects do not work for me (and replying to this issue by email doesn't work either.)

ok.

I see there was a problem with the lvm2 one. There was a ; that gitweb wasn't processing correctly.
I've fixed that.

So, currently:

https://git.fedorahosted.org/git/lvm2.git -> https://sourceware.org/git/?p=lvm2.git
https://git.fedorahosted.org/git/sanlock.git -> https://pagure.io/sanlock
https://git.fedorahosted.org/git/dlm.git -> https://pagure.io/dlm

Is that what you wanted?

What I'm trying to do is redirect links to git commits in the old git trees to the same commits in the new git tree. Those simple substitutes don't look like they would do that.

This old url:
https://git.fedorahosted.org/cgit/lvm2.git/commit/?id=c0f2a59993e373781c6dd5568cd559547cfe49a1

should be redirected to the same commit in the new sourceware git tree:
https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=c0f2a59993e373781c6dd5568cd559547cfe49a1

The same for sanlock and dlm urls,

https://git.fedorahosted.org/cgit/sanlock.git/commit/?id=fa70eff67e327b181e3d006a3381ae8e32822084

should be redirected to:
https://pagure.io/sanlock/c/fa70eff67e327b181e3d006a3381ae8e32822084?branch=master

The old urls are referenced from bugzillas, mailing lists, etc, which is why they should continue working.

Well, down this road is madness. We tried to add redirects from gitweb to cgit when we changed, and it was an endless sink of dispair. You tweak something to get X working and Y breaks. It becomes a tower of doom. :cry:

I can try and handle the above cases, but to be clear we definitely cannot handle every case here.

I've just spent an hour and have the above commit case working for those projects.

Can you check ?

They are working for me, thanks for getting that figured out. I can see how getting all the different possible urls redirected would be difficult, so that should be good enough.

Great.

:outbox_tray:

Kevin,

I've hit another example of being redirected to the fedorahosted retirement page when trying to access a patch that was pointed to from a RHEL bug we are working with an engineering partner:

https://git.fedorahosted.org/cgit/lvm2.git/patch/?id=6a20b221516fcecda25bc56996028eb50b3250f8

As you noted "a day ago" from when I post this comment, chasing down every variation of url to redirect is going to land you in the pit of despair. Would it be possible to create a default redirect to the LVM2 sourceware git home page for any redirect you haven't already addressed? At least that way people would be redirected the LVM2 sources and could find their way from there.

Travis

ok. I fixed that case and added a general one for everything else to just go to the top of the new repo.