#8622 review-stats script is failing
Closed: Fixed 4 years ago by cverna. Opened 4 years ago by tibbs.

A few days ago I started getting failure messages from the review-stats cron job. At first I thought they were only on staging (and I do occasionally see random failures of this script in staging) but I recently noticed that I was seeing them in production as well.

Looks like permissions got changed somewhere and now the config file (/usr/local/share/review-stats/review-stats.cfg) can't be read by the user running the script (apache). I guess it could be either an issue with standard permissions or it could be an selinux thing.

From: "(Cron Daemon)" <apache@stg.fedoraproject.org>
Subject: Cron <apache@sundries01> /usr/local/bin/review-stats.py -c /usr/local/share/review-stats/review-stats.cfg -t /usr/local/share/review-stats/templates -d /srv/web/review-stats/

Traceback (most recent call last):
  File "/usr/local/bin/review-stats.py", line 626, in <module>
    config = parse_config(options.configfile)
  File "/usr/local/bin/review-stats.py", line 81, in parse_config
    cfg = ConfigObj(file, configspec=spec)
  File "/usr/lib/python2.7/site-packages/configobj.py", line 1242, in __init__
    self._load(infile, configspec)
  File "/usr/lib/python2.7/site-packages/configobj.py", line 1249, in _load
    h = open(infile, 'rb')
IOError: [Errno 13] Permission denied: '/usr/local/share/review-stats/review-stats.cfg'

@mattia worked on a replacement in #5315 so we should probably look at deploying that. No sure tho when someone will have time to look at it.

Metadata Update from @cverna:
- Issue assigned to cverna

4 years ago

I have pushed https://infrastructure.fedoraproject.org/cgit/ansible.git/commit/?id=bf068c51ff8bab3e9c38db2b694fe47ed10c2152

and run the following playbook ansible-playbook /srv/web/infra/ansible/playbooks/groups/sundries.yml

That should fix this issue. I ll monitor the cron job errors and close the ticket if everything works.

Metadata Update from @kevin:
- Issue priority set to: Waiting on Assignee (was: Needs Review)

4 years ago

I did not see any failures from the cron (but I dod get a lot so might have missed it). Closing this but feel free to reopen if that happens again.

Metadata Update from @cverna:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

4 years ago

Login to comment on this ticket.

Metadata