When pushing to project's master branch (koji/master) I'm getting tracebacks from commit hooks. It looks that pagure is not able to send messages to fedmsg in such case. As our sync script is also missing some other updates (e.g. release change or tag change in the issue/PR) it is possible that it is not only commit hook.
<img alt="pagure_push_error" src="/fedora-infrastructure/issue/raw/files/5fa5bc30ac334289c62b9925e70f180b6f4c0e27c18c772f8bc613258b9d7080-pagure_push_error" />
Metadata Update from @pingou: - Issue assigned to pingou
I believe this should be fixed by the upgrade to pagure 5.13 which I was just working on :)
Could you try again now?
Still the same error.
remote: 2021-02-02 13:45:58,313 [ERROR] pagure.lib.notify: Error sending fedora-messaging message remote: Traceback (most recent call last): remote: File "/usr/lib/python3.6/site-packages/pagure/lib/notify.py", line 99, in fedora_messaging_publish remote: fedora_messaging.api.publish(msg) remote: File "/usr/lib/python3.6/site-packages/fedora_messaging/api.py", line 313, in publish remote: eventual_result.wait(timeout=timeout) remote: File "/usr/lib/python3.6/site-packages/crochet/_eventloop.py", line 241, in wait remote: result.raiseException() remote: File "/usr/lib64/python3.6/site-packages/twisted/python/failure.py", line 488, in raiseException remote: raise self.value.with_traceback(self.tb) remote: jsonschema.exceptions.ValidationError: {'name': 'Size', 'key_type': 'list', 'value': 'None', 'key_data': '["small", "medium", "large", "unknown"]'} is not of type 'array' remote: remote: Failed validating 'type' in schema['properties']['issue']['properties']['custom_fields']['items']: remote: {'items': {'type': 'string'}, 'type': 'array'} remote: remote: On instance['issue']['custom_fields'][0]: remote: {'key_data': '["small", "medium", "large", "unknown"]', remote: 'key_type': 'list', remote: 'name': 'Size', remote: 'value': 'None'}
ah, I think I see it, is it better now?
Hmm, I've nothing more to push today :-) I'll update the ticket (maybe tomorrow).
At least I can say I've not received any notification of error on this (I receive emails upon errors in pagure)
Metadata Update from @smooge: - Issue priority set to: Waiting on Reporter (was: Needs Review) - Issue tagged with: medium-gain, medium-trouble, ops, pagure
Metadata Update from @smooge: - Issue untagged with: ops - Issue tagged with: dev
So, it doesn't have traceback today, but warning is still there (maybe it is ok?):
$ git push Enumerating objects: 1, done. Counting objects: 100% (1/1), done. Writing objects: 100% (1/1), 320 bytes | 320.00 KiB/s, done. Total 1 (delta 0), reused 0 (delta 0), pack-reused 0 remote: Has commit access: True remote: Sending to redis to log activity and send commit notification emails remote: * Publishing information for 2 commits remote: - to fedora-message remote: 2021-02-03 12:14:52,382 [WARNING] pagure.lib.notify: pagure is about to send a message that has no schemas: pagure.git.receive remote: - to stomp remote: - to mqtt remote: Detailed log of new commits: remote: remote: remote: * commit 3e8f8000c8029a62c52d6dd75cfcdf91c9d5fcc2 remote: * Merge: 0c4db061 8b9aa559 remote: * Author: Tomas Kopecek <tkopecek@redhat.com> remote: * Date: Wed Feb 3 13:14:37 2021 +0100 remote: * remote: * PR#2680: fix the mode of tarfile.open remote: * remote: * Merges #2680 remote: 2021-02-03 12:14:53,197 [WARNING] pagure.lib.notify: pagure is about to send a message that has no schemas: pagure.pull-request.comment.added remote: 2021-02-03 12:14:53,620 [WARNING] pagure.lib.notify: pagure is about to send a message that has no schemas: pagure.pull-request.comment.added remote: 2021-02-03 12:14:53,734 [WARNING] pagure.lib.notify: pagure is about to send a message that has no schemas: pagure.pull-request.closed remote: * https://pagure.io/koji/pull-request/2680 remote: * remote: * Fixes: #2641 remote: 2021-02-03 12:14:54,075 [WARNING] pagure.lib.notify: pagure is about to send a message that has no schemas: pagure.issue.comment.added remote: * https://pagure.io/koji/issue/2641 remote: * "open" encoding is defined outside of koji remote: * remote: * commit 8b9aa559c82f3d4a22e3836a3deed9b02e12893a remote: * Author: Yu Ming Zhu <yzhu@redhat.com> remote: * Date: Wed Feb 3 10:04:38 2021 +0000 remote: * remote: * fix the mode of tarfile.open remote: * remote: * fixes: #2641 remote: 2021-02-03 12:14:54,581 [WARNING] pagure.lib.notify: pagure is about to send a message that has no schemas: pagure.issue.comment.added To ssh://pagure.io/koji.git 0c4db061..3e8f8000 master -> master
The error remote: 2021-02-03 12:14:54,075 [WARNING] pagure.lib.notify: pagure is about to send a message that has no schemas: pagure.issue.comment.added can actually be ignored, we can check datagrepper but I'm confident that the messages are sent well.
remote: 2021-02-03 12:14:54,075 [WARNING] pagure.lib.notify: pagure is about to send a message that has no schemas: pagure.issue.comment.added
I need to figure out why the warning is being trigger, it really shouldn't.
I think this is all back to working. Please re-open or file a new ticket if you are still seeing any issues.
Metadata Update from @kevin: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.