Two asks:

1. Please reference the upstream issue on the iot-distro tracker for additional context in the commit message

2. Do a thorough comparison of the RPMs included in the osbuild code for an iot-commit artifact (maybe even build the iot-commit for reference) and make sure there are no other differences

Adds ssh-key-dir and ignition-edge packages to base yaml.

Is ignition-edge a ssh package? Also explain why your adding them, the addition is kind of explained by the patch itself, but the commit message should explain the why bit of the equation :)

Two asks:

1. Please reference the upstream issue on the iot-distro tracker for additional context in the commit message

2. Do a thorough comparison of the RPMs included in the osbuild code for an iot-commit artifact (maybe even build the iot-commit for reference) and make sure there are no other differences

I found a couple other packages in the osbuild iot-commit code that are not present here:
- dnsmasq
- fdo-owner-cli
- nss-altfiles
- fedora-iot-config

Should I add some/all of those packages to this pull request?

I updated the PR description but I cannot update the commit message, pagure won't let me authenticate for a push from my clone because I'm not a maintainer (I believe this is my issue: https://discussion.fedoraproject.org/t/i-cannot-send-my-changes-into-my-pagure-fork-because-auth-is-invalid/77090).

Should I pull down this pr and try to put it up again through an anonymous clone?

Adds ssh-key-dir and ignition-edge packages to base yaml.

Is ignition-edge a ssh package? Also explain why your adding them, the addition is kind of explained by the patch itself, but the commit message should explain the why bit of the equation :)

ignition-edge is a support package that is needed for ssh-key-dir to work properly. I don't know the nitty gritty as to what exactly it does, if you'd like me to find all that out I can look for it.

Thanks for the additional investigation!

I found a couple other packages in the osbuild iot-commit code that are not present here:
- dnsmasq

We dropped this one already - https://github.com/fedora-iot/iot-distro/issues/60

• fdo-owner-cli

Yes; part of the FDO set of packages and a useful tool

• nss-altfiles

This is necessary for how rpm-ostree handles users, so I think this is necessary

• fedora-iot-config

I think this should get included as I believe it contains the config for the IoT ostree remote, but that might be configured as part of the compose process in Fedora.

@pwhalen can you weigh in here?

• fedora-iot-config

I think this should get included as I believe it contains the config for the IoT ostree remote, but that might be configured as part of the compose process in Fedora.

Yes, needs to be included

I think this should get included as I believe it contains the config for the IoT ostree remote, but that might be configured as part of the compose process in Fedora.

@pwhalen can you weigh in here?

Currently fedora-iot-config gets pulled in as a requires for fedora-release-iot , for clarity we should likely add it here too.

https://src.fedoraproject.org/rpms/fedora-release/blob/rawhide/f/fedora-release.spec#_517

@djachimo while you are in this file, could you add a comment at the top of the packages section explaining that the list of packages should be kept in sync with the iot-commit definition in the osbuild code (and vice-versa)? With a permalink to the osbuild code reference, please.

Just updated this pr with all the packages to be added, nss-altfiles was already there so I think I was just blind and missed it before. I tested this twice, once with just the ssh related packages and again with all the packages. Both times I was able to ssh in, with a .ssh directory and a home directory created. I think this is good to go.

LGTM! Thanks for digging into this!

LGTM, thanks @djachimo