Hm, after reading a bit it seems kwallet's secrets implementation is not yet complete, https://bugs.kde.org/show_bug.cgi?id=466197

Not sure what the best course of action here is.

As long as it works it should be no problem. But test it, layering and overwriting is possible. Report if all apps work. I would think of Spot as an app that needs it.

The only app I tested that didn't work out of the box was the Minecraft Launcher, I had to allow it to talk to the secrets dbus with Flatseal for it to work. Spot, XIVLauncher, Déjà Dup and Intellij IDEA Ultimate all work fine with no modification.

I did copy the kwallet dbus session file from the Archwiki though, that was required for anything to work. https://wiki.archlinux.org/title/KDE_Wallet#Automatic_D-Bus_activation

Does anyone know why this is not upstream?

Does anyone know why this is not upstream?

I assume you're talking about the dbus service file? This bug report mentions it, but hasn't seen any activity since it was opened: https://bugs.kde.org/show_bug.cgi?id=458339

Does anyone know why this is not upstream?

@siosm https://invent.kde.org/frameworks/kwallet/-/merge_requests/67#note_9e7bd8ef1ccd16192e4d96731eaa859455368361
It looks like the change got merged https://bugs.kde.org/show_bug.cgi?id=466197
Do we know what else would be blocking this?

If someone can try out on a fresh KDE Spin / Kinoite installation that removing gnome-keyring and relying on this works well then we should move forward with this.

If someone can try out on a fresh KDE Spin / Kinoite installation that removing gnome-keyring and relying on this works well then we should move forward with this.

I created a new Kinoite VM and removed gnome-keyring and gnome-keyring-pam. I added the dbus file and used the nheko matrix client flatpak (flathub version) to test if the password was saved to kwallet. It successfully saved in a folder called Secret Service in kwallet.

Please let me know if there is something else you need me to test.

Awesome! Thanks for doing that. Where did you get the dbus file from? Let's move it either upstream or in our package?

Awesome! Thanks for doing that. Where did you get the dbus file from? Let's move it either upstream or in our package?

So I went ahead and looked to see if adding the dbus service file separately was necessary and it appears that the dbus file already exists in /usr/share/dbus-1/services/org.kde.kwalletd6.service

I tested in a separate VM and confirmed that I was able to get the same behaviour without adding a dbus file separately. I think this can be closed since that secrets implementation takes care of the necessary service file creation as far as I can tell. The gnome-keyring and gnome-keyring-pam would just need to be removed

To be clear:
I was able to successfully remove the gnome-keyring and gnome-keyring-pam and use nheko flatpak without a problem in the new vm without adding a separate dbus service file since /usr/share/dbus-1/services/org.kde.kwalletd6.service was already there in the fresh install. I was also able to confirm that kwalletmanager had the Secret Service folder after logging in to nheko.

Thanks for testing that! Let's remove those packages for F41: https://pagure.io/fedora-comps/pull-request/978

And this is done for Kinoite in F41: https://pagure.io/workstation-ostree-config/pull-request/532