Will fix: https://pagure.io/fedora-kde/SIG/issue/549

I've now fully tested it as working on Fedora Kinoite. Not tested on KDE Spin.

Can we please flip this logic? In other words, use if (root.isOstree) instead?

Is there a way to flag the OpenH264 page to not show up if OpenH264 is already installed?

Can we please flip this logic? In other words, use if (root.isOstree) instead?

Is there a way to flag the OpenH264 page to not show up if OpenH264 is already installed?

I'm not sure there / I don't know how to do it.

Can we please flip this logic? In other words, use if (root.isOstree) instead?

Done

Is there a way to flag the OpenH264 page to not show up if OpenH264 is already installed?

I'm not sure there / I don't know how to do it.

Then could we gray out the button instead of offering a way to uninstall it?

@ngompa would there be a way in the spec to delete the file if they are NOT in an rpmostree system?

No.

We could subpackage the page, though.

@ngompa would there be a way in the spec to delete the file if they are NOT in an rpmostree system?

The goal is not to remove the page on ostree systems but to remove it on systems where openh264 is already installed, ostree or not, so it has to be dynamic

We'll likely have to ask upstream if and how to do it.

Yeah, it's not just that though. Fedora Asahi systems will almost always have OpenH264 installed before first login, so this page would be superfluous in that case.

I've filed: https://bugs.kde.org/show_bug.cgi?id=491061

Is there a way to flag the OpenH264 page to not show up if OpenH264 is already installed?

I'm not sure there / I don't know how to do it.

Then could we gray out the button instead of offering a way to uninstall it?

If we offer a way to install it then we should offer the reverse as well, other wise it's going to be confusing to users if they click on the button by mistake.

Or we completely disable the button and both pages if the third party repos / openh264 are already installed and remove the button once clicked installed as the installation will happen in the background anyway and won't be instant so you won't be able to directly uninstall it.

Maybe we need a small KCM page in the settings that is capable of adding/removing those so that we have a place to point users to after the plasma-welcome screen.

According to https://pagure.io/fedora-kde/SIG/issue/549#comment-921374 it's not need for the KDE Spin and only for Kinoite so indeed we can split this into a another sub-package.

We'd also want the skip logic so that these pages don't show up every time plasma welcome relaunches with new Plasma versions, so the RFE is still useful.

We'd also want the skip logic so that these pages don't show up every time plasma welcome relaunches with new Plasma versions, so the RFE is still useful.

That's not the same thing. The thing that pops when plasma gets updated afaik does not pop the custom pages, it's just that "You have been upgraded to plasma 6.x!" page.

Just double-checked, correct. Those pages don't show there.

@siosm Is this good to go?

Let's hold on this one for F41 and I'll try it in F42. I'll try to do the workaround from https://bugs.kde.org/show_bug.cgi?id=491061.

I think it's unlikely we'll do this one as we are trying to move away from package layering, especially for default setup, so let's close it.