PR#1015: container-toolbox: Use 'toolbx' as VARIANT_ID in os-release(5) - fedora-kickstarts

fedora-kickstarts

#1015 container-toolbox: Use 'toolbx' as VARIANT_ID in os-release(5)

Merged 3 months ago by ngompa. Opened 3 months ago by rishi.

rishi/fedora-kickstarts wip/rishi/toolbx-fedora-release-toolbx into main

container-toolbox: Use 'toolbx' as VARIANT_ID in os-release(5)

Debarshi Ray • 3 months ago

0d99c64

fedora-container-toolbox.ks

file modified

+1 -1

		`@@ -33,7 +33,7 @@`
		`dnf-plugins-core`
		`-dosfstools`
		`-e2fsprogs`
		`- fedora-release-container`
		`+ fedora-release-toolbx`
		`findutils`
		`flatpak-spawn`
		`fpaste`

rishi commented 3 months ago

This is meant to distinguish OCI containers and images that are designed
specifically for Toolbx from others. Toolbx containers are long-lasting
pet containers for interactive command line use, which makes them
substantially different from short-lived containers running services.

Therefore, it can be useful to be able to identify Toolbx containers and
images when generating statistics about Fedora usage.

https://pagure.io/Fedora-Council/tickets/issue/449

rebased onto 61fe17f81aaa3115c43d549ed9860493fc66b4d6

3 months ago

rishi commented 3 months ago

My attempt at a scratch build failed with:

Exception encountered in _build_image_from_template thread
module 'configparser' has no attribute 'SafeConfigParser'
Traceback (most recent call last):
  File "/usr/lib/python3.12/site-packages/imgfac/Builder.py", line 135, in _build_image_from_template
    self.os_plugin.create_base_image(self, template, parameters)
  File "/usr/lib/python3.12/site-packages/imagefactory_plugins/TinMan/TinMan.py", line 320, in create_base_image
    self._init_oz()
  File "/usr/lib/python3.12/site-packages/imagefactory_plugins/TinMan/TinMan.py", line 272, in _init_oz
    self.oz_config = configparser.SafeConfigParser()
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'configparser' has no attribute 'SafeConfigParser'. Did you mean: 'RawConfigParser'?
ABORT called in TinMan plugin

ngompa commented 3 months ago

Can you please send the change to https://pagure.io/fedora-kiwi-descriptions instead, since the image build will be moving over there?

rishi commented 3 months ago

Can you please send the change to https://pagure.io/fedora-kiwi-descriptions instead, since the image build will be moving over there?

Yeah, I was going to get to that. When are we making the switch?

The Kiwi definition for fedora-toolbox might need some untangling from the fedora and fedora-minimal images, so it might not be a one line change.

rishi commented 3 months ago

A scratch build with --can-fail aarch64 got me some success:
https://koji.fedoraproject.org/koji/taskinfo?taskID=113120501

ngompa commented 3 months ago

Can you please send the change to https://pagure.io/fedora-kiwi-descriptions instead, since the image build will be moving over there?

Yeah, I was going to get to that. When are we making the switch?

The pungi PR was just made a couple of days ago: https://pagure.io/pungi/pull-request/1720

I'm hoping we can start doing something with it using koji-staging and get things switched over in the next couple of weeks.

The Kiwi definition for fedora-toolbox might need some untangling from the fedora and fedora-minimal images, so it might not be a one line change.

Oof.