#40 correct ostree repo location
Merged 7 years ago by ausil. Opened 7 years ago by jasonbrooks.
jasonbrooks/fedora-kickstarts pr-fix-ostreesetup-url  into  f24

file modified
+1 -1
@@ -33,7 +33,7 @@ 

  logvol / --size=3000 --fstype="xfs" --name=root --vgname=atomicos

  

  # Equivalent of %include fedora-repo.ks

- ostreesetup --nogpg --osname=fedora-atomic --remote=fedora-atomic --url=https://kojipkgs.fedoraproject.org/mash/atomic/24/ --ref=fedora-atomic/24/x86_64/docker-host

+ ostreesetup --nogpg --osname=fedora-atomic --remote=fedora-atomic --url=https://kojipkgs.fedoraproject.org/atomic/24/ --ref=fedora-atomic/24/x86_64/docker-host

  

  reboot

  

Both of the url versions seem to point to the same thing. How do I verify the new one is correct?
I do want to do an update for spin-kickstarts in f24 soon, so I want to include this pull request if it is correct.

While in this case it is probably OK to leave things as they are, referring to the Fedora version by absolute number isn't a good idea. This hasn't been changed in the master branch yet which still refers to 25 instead of 26. If possible the correct version should get pulled from somewhere at run time so things don't need to get changed every branch.

I meant leaving them as they are for f24. It would be good to fix this for f25 and master.

Also related is that fedora-cloud-atomic-pxetolive.ks has a refernce to f22 in f24, f25 and master.

Pull-Request has been merged by ausil

7 years ago

Something went wrong with the merge. I filed an issue for this against pagure. I'll redo this if there isn't a fix from pagure that makes the commit visible soon.

Metadata