PR#921: Clean up KDE package lists - fedora-kickstarts

fedora-kickstarts

#921 Clean up KDE package lists

Closed a year ago by adamwill. Opened 2 years ago by adamwill.

kde-cleanups into main

Clean up KDE package lists

Adam Williamson • 2 years ago

0b2fe86

fedora-kde-common.ks

file modified

+5 -29

		`@@ -19,43 +19,19 @@`

		`### fixes`

		`- # use kde-print-manager instead of system-config-printer`
		`- -system-config-printer`
		`- # make sure mariadb lands instead of MySQL (hopefully a temporary hack)`
		`- mariadb-embedded`
		`- mariadb-connector-c`
		`- mariadb-server`
		`-`
		`# minimal localization support - allows installing the kde-l10n-* packages`
		`kde-l10n`

		`- # unwanted packages from @kde-desktop`
		`- # don't include these for now to fit on a cd`
		`- -desktop-backgrounds-basic`
		`- -kdeaccessibility*`
		`- -ktorrent # kget has also basic torrent features (~3 megs)`
		`- -digikam # digikam has duplicate functionality with gwenview (~28 megs)`
		`- -kipi-plugins # ~8 megs + drags in Marble`
		`- -krusader # ~4 megs`
		`- -k3b # ~15 megs`
		`-`
		`- #-kdeplasma-addons # ~16 megs`
		`-`
		`# Additional packages that are not default in kde-* groups, but useful`
		`- #kdeartwork # only include some parts of kdeartwork`
		`fuse`
		`mediawriter`

		`### space issues`
		`-`
		`- # admin-tools`
		`- -gnome-disk-utility`
		`- # kcm_clock still lacks some features, so keep system-config-date around`
		`- #-system-config-date`
		`- # prefer kcm_systemd`
		`- -system-config-services`
		`- # prefer/use kusers`
		`- -system-config-users`
		`+ -ktorrent # kget has also basic torrent features (~3 megs)`
		`+ -digikam # digikam has duplicate functionality with gwenview (~28 megs)`
		`+ -kipi-plugins # ~8 megs + drags in Marble`
		`+ -krusader # ~4 megs`
		`+ -k3b # ~15 megs`

		`## avoid serious bugs by omitting broken stuff`

fedora-kde-minimization.ks

file removed

-7

		`@@ -1,7 +0,0 @@`
		`- # remove input methods to free space`
		`- %packages`
		`- -scim*`
		`- -iok`
		`- %end`
		`-`
		`-`

fedora-live-kde.ks

file modified

-1

		`@@ -9,7 +9,6 @@`

		`%include fedora-live-kde-base.ks`
		`%include fedora-live-minimization.ks`
		`- %include fedora-kde-minimization.ks`

		`# DVD payload`
		`part / --size=7500`

adamwill commented 2 years ago

fedora-kde-minimization.ks only tried to remove scim* and iok.
iok hasn't existed since F30. scim* packages still exist, but
nothing requires or recommends any of them, and none of them are
listed as default or mandatory in comps, so I don't think this
does anything.

mariadb: we do still ship both mariadb and community-mysql, and
they have overlapping provides. However, the only thing that
requires 'mysql-server' is kf5-akonadi-server-mysql , and that
also recommends 'mariadb-server', which should break the tie
without needing these lines.

system-config-*: none of these exist any more.

desktop-backgrounds-basic: no longer listed in base-x.

gnome-disk-utility: we already drop the entire admin-tools
group above, so there's no need to try and drop one package from
it too.

kdeaccessibility and kdeartwork don't exist any more.

Commented-out lines were dropped, there's no point having
commented-out lines with no explanation why they're there.

Signed-off-by: Adam Williamson awilliam@redhat.com

adamwill commented 2 years ago

oh, sorry - system-config-printer does exist, but nothing pulls it into KDE any more, I don't think. The printing group lists only system-config-printer-udev as default, system-config-printer is optional.

adamwill commented 2 years ago

@ngompa @marcdeop

justinz commented a year ago

Ping.

ngompa commented a year ago

👌

ngompa commented a year ago

@adamwill this fails to rebase, can you take a look?

adamwill commented a year ago

will do, tomorrow.

adamwill commented a year ago

Huh, this is weird. It rebases fine locally, but I cannot push it, because a hook is claiming it's not a fast-forward push:

[adamw@xps13a fedora-kickstarts (kde-cleanups)]$ git push
To ssh://pagure.io/fedora-kickstarts.git
 ! [rejected]        kde-cleanups -> kde-cleanups (non-fast-forward)
error: failed to push some refs to 'ssh://pagure.io/fedora-kickstarts.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

but it...is. It only has one commit on top of current main, the commit from the PR. It's definitely ahead of the current version of the branch. So, I've never seen that before, not sure how to fix it, anyone else know?

adamwill commented a year ago

oh wait never mind, I see from the log it's pushing to the wrong remote. Duh.

adamwill commented a year ago

hmm, no, still busted. I pushed it to my fork, and that worked, but the PR still wants to merge from the same-named branch on the upstream repo, which I can't push to...maybe I can delete it...

adamwill commented a year ago

welp, I deleted the branch but that didn't help. Just gonna close this PR and open a new one, I guess.

adamwill commented a year ago

welp, I deleted the branch but that didn't help. Just gonna close this PR and open a new one, I guess.

Pull-Request has been closed by adamwill

a year ago

adamwill commented a year ago

Re-created as https://pagure.io/fedora-kickstarts/pull-request/933 .