#995 container-toolbox: Include weak dependencies
Merged 7 months ago by humaton. Opened 7 months ago by rishi.

file modified
+1 -1
@@ -6,7 +6,7 @@ 

  %include fedora-container-common.ks

  

  # Install packages

- %packages --inst-langs=en --nocore --exclude-weakdeps

+ %packages --inst-langs=en --nocore

  acl

  bash

  bash-completion

The Container/Dockerfile equivalent of the fedora-toolbox OCI images
didn't exclude weak dependencies [1] so the Kickstart shouldn't either.

The fedora-toolbox OCI image is meant for interactive command line
environments, not for deploying server applications. Therefore, they
need a fully featured CLI user experience at par with what's offered on
Fedora Silverblue and Workstation. Among the Kickstart files defined
here, other than fedora-container-toolbox.ks, only these ones exclude
weak dependencies:
* fedora-container-base-minimal.ks
* fedora-container-base.ks
* fedora-container-common.ks
* fedora-eln-container-base.ks
* fedora-modular-disk-minimal.ks

None of the other Kickstarts, and definitely not those for Fedora
Workstation, exclude weak dependencies.

As a concrete example, the default-editor meta RPM relies on Recommends
for its functionality [2].

[1] https://src.fedoraproject.org/container/fedora-toolbox
https://github.com/containers/toolbox/tree/main/images/fedora

[2] fedora nano commit e53ee57baa33a1d8
https://src.fedoraproject.org/rpms/nano/c/e53ee57baa33a1d8
https://src.fedoraproject.org/rpms/nano/pull-request/7
https://bugzilla.redhat.com/show_bug.cgi?id=1955884

rebased onto 5f656dfb925b259e22f823be1c60dbaedca49536

7 months ago

Every other Kickstart in the repository uses --excludeWeakdeps, while fedora-container-toolbox.ks had --exclude-weakdeps. Is that alright?

I also couldn't spot this option in the documentation:
https://docs.fedoraproject.org/en-US/fedora/f36/install-guide/appendixes/Kickstart_Syntax_Reference/

rebased onto e8cf44b9df4a7b001d161605113f38dddb887b3d

7 months ago

rebased onto c808f28ab9e4c38276943cff0571d555b8e61fcf

7 months ago

rebased onto 49306cb

7 months ago

Pull-Request has been merged by humaton

7 months ago

This was accepted as a Final Freeze exception for Fedora 39:
https://bugzilla.redhat.com/show_bug.cgi?id=2244503

Metadata