PR#996: [f39] container-toolbox: Include weak dependencies - fedora-kickstarts

fedora-kickstarts

#996 [f39] container-toolbox: Include weak dependencies

Merged 7 months ago by humaton. Opened 7 months ago by rishi.

rishi/fedora-kickstarts wip/rishi/container-toolbox-include-weakdeps-f39 into f39

container-toolbox: Include weak dependencies

Debarshi Ray • 7 months ago

b5fc5fd

fedora-container-toolbox.ks

file modified

+1 -1

		`@@ -6,7 +6,7 @@`
		`%include fedora-container-common.ks`

		`# Install packages`
		`- %packages --inst-langs=en --nocore --exclude-weakdeps`
		`+ %packages --inst-langs=en --nocore`
		`acl`
		`bash`
		`bash-completion`

rishi commented 7 months ago

The Container/Dockerfile equivalent of the fedora-toolbox OCI images
didn't exclude weak dependencies [1] so the Kickstart shouldn't either.

The fedora-toolbox OCI image is meant for interactive command line
environments, not for deploying server applications. Therefore, they
need a fully featured CLI user experience at par with what's offered on
Fedora Silverblue and Workstation. Among the Kickstart files defined
here, other than fedora-container-toolbox.ks, only these ones exclude
weak dependencies:
* fedora-container-base-minimal.ks
* fedora-container-base.ks
* fedora-container-common.ks
* fedora-eln-container-base.ks
* fedora-modular-disk-minimal.ks

None of the other Kickstarts, and definitely not those for Fedora
Workstation, exclude weak dependencies.

[1] https://src.fedoraproject.org/container/fedora-toolbox
https://github.com/containers/toolbox/tree/main/images/fedora

https://bugzilla.redhat.com/show_bug.cgi?id=2244503

rebased onto 77f8d3c4dbbb24fc36e63cc39a1be4f201deff38

7 months ago

rishi commented 7 months ago

Corresponding pull request for main: https://pagure.io/fedora-kickstarts/pull-request/995

rebased onto 223f2c742af712045e1efb868b3ac1f605a2421e

7 months ago

rebased onto c6d95b4f832c74501b4fd896587a2fba51180705

7 months ago

rishi commented 7 months ago

Goes on top of https://pagure.io/fedora-kickstarts/pull-request/994

rebased onto bbd9f3c

7 months ago

rebased onto b5fc5fd

7 months ago

rishi commented 7 months ago

We do have a Final Freeze exception for Fedora 39 now for this.

This commit has already been part of the fedora-toolbox:40 image for a few days now and I haven't spotted any problems from that. So I think it's time to merge this one to f39.