PR#43: cloud: Consistent device naming - fedora-kiwi-descriptions

fedora-kiwi-descriptions

#43 cloud: Consistent device naming

Merged 2 months ago by ngompa. Opened 2 months ago by mhayden.

mhayden/fedora-kiwi-descriptions device-naming into rawhide

Major Hayden • 2 months ago

72083f7

teams/cloud/cloud.xml

file modified

+6 -6

		`@@ -31,7 +31,7 @@`
		`<preferences profiles="Cloud-Base-Azure" arch="x86_64,aarch64">`
		`<type image="oem" format="vhd-fixed" formatoptions="force_size"`
		`filesystem="btrfs" btrfs_root_is_subvolume="true" btrfs_set_default_volume="false" fsmountoptions="compress=zstd:1"`
		`- kernelcmdline="no_timer_check net.ifnames=0 console=tty1 console=ttyS0,115200n8 earlyprintk=ttyS0"`
		`+ kernelcmdline="no_timer_check console=tty1 console=ttyS0,115200n8 earlyprintk=ttyS0"`
		`devicepersistency="by-uuid"`
		`bootpartition="true" bootpartsize="1000" bootfilesystem="ext4" efipartsize="100" firmware="uefi"`
		`rootfs_label="fedora"`
		`@@ -51,7 +51,7 @@`
		`<preferences profiles="Cloud-Base-AmazonEC2" arch="x86_64,aarch64">`
		`<type image="oem"`
		`filesystem="btrfs" btrfs_root_is_subvolume="true" btrfs_set_default_volume="false" fsmountoptions="compress=zstd:1"`
		`- kernelcmdline="no_timer_check net.ifnames=0 console=tty1 console=ttyS0,115200n8"`
		`+ kernelcmdline="no_timer_check console=tty1 console=ttyS0,115200n8"`
		`devicepersistency="by-uuid"`
		`bootpartition="true" bootpartsize="1000" bootfilesystem="ext4" efipartsize="100" firmware="uefi"`
		`rootfs_label="fedora"`
		`@@ -71,7 +71,7 @@`
		`<preferences profiles="Cloud-Base-GCE" arch="x86_64,aarch64">`
		`<type image="oem" format="gce"`
		`filesystem="btrfs" btrfs_root_is_subvolume="true" btrfs_set_default_volume="false" fsmountoptions="compress=zstd:1"`
		`- kernelcmdline="no_timer_check net.ifnames=0 console=ttyS0,38400n8d"`
		`+ kernelcmdline="no_timer_check console=ttyS0,38400n8d"`
		`devicepersistency="by-uuid"`
		`bootpartition="true" bootpartsize="1000" bootfilesystem="ext4" efipartsize="100" firmware="uefi"`
		`rootfs_label="fedora"`
		`@@ -92,7 +92,7 @@`
		`<preferences profiles="Cloud-Base-Generic" arch="x86_64,aarch64">`
		`<type image="oem" format="qcow2"`
		`filesystem="btrfs" btrfs_root_is_subvolume="true" btrfs_set_default_volume="false" fsmountoptions="compress=zstd:1"`
		`- kernelcmdline="no_timer_check net.ifnames=0 console=tty1 console=ttyS0,115200n8"`
		`+ kernelcmdline="no_timer_check console=tty1 console=ttyS0,115200n8"`
		`devicepersistency="by-uuid"`
		`bootpartition="true" bootpartsize="1000" bootfilesystem="ext4" efipartsize="100" firmware="uefi"`
		`rootfs_label="fedora"`
		`@@ -112,7 +112,7 @@`
		`<preferences profiles="Cloud-Base-Generic" arch="ppc64le">`
		`<type image="oem" format="qcow2"`
		`filesystem="btrfs" btrfs_root_is_subvolume="true" btrfs_set_default_volume="false" fsmountoptions="compress=zstd:1"`
		`- kernelcmdline="no_timer_check net.ifnames=0 console=tty1 console=ttyS0,115200n8"`
		`+ kernelcmdline="no_timer_check console=tty1 console=ttyS0,115200n8"`
		`devicepersistency="by-uuid" target_blocksize="4096"`
		`bootpartition="true" bootpartsize="1000" bootfilesystem="ext4" firmware="ofw"`
		`rootfs_label="fedora"`
		`@@ -132,7 +132,7 @@`
		`<preferences profiles="Cloud-Base-Generic" arch="s390x">`
		`<type image="oem" format="qcow2"`
		`filesystem="btrfs" btrfs_root_is_subvolume="true" btrfs_set_default_volume="false" fsmountoptions="compress=zstd:1"`
		`- kernelcmdline="no_timer_check net.ifnames=0 console=tty1 console=ttyS0,115200n8 dasd_mod.dasd=ipldev"`
		`+ kernelcmdline="no_timer_check console=tty1 console=ttyS0,115200n8 dasd_mod.dasd=ipldev"`
		`devicepersistency="by-uuid" target_blocksize="4096"`
		`bootpartition="true" bootpartsize="1000" bootfilesystem="ext4"`
		`rootfs_label="fedora"`

teams/cloud/vagrant.xml

file modified

+2 -2

		`@@ -13,7 +13,7 @@`
		`<preferences profiles="Cloud-Base-Vagrant-libvirt" arch="x86_64,aarch64">`
		`<type image="oem" format="vagrant"`
		`filesystem="btrfs" btrfs_root_is_subvolume="true" btrfs_set_default_volume="false" fsmountoptions="compress=zstd:1"`
		`- kernelcmdline="no_timer_check console=tty1 console=ttyS0,115200n8 net.ifnames=0 biosdevname=0"`
		`+ kernelcmdline="no_timer_check console=tty1 console=ttyS0,115200n8"`
		`devicepersistency="by-uuid"`
		`bootpartition="true" bootpartsize="1000" bootfilesystem="ext4" efipartsize="100" firmware="uefi"`
		`rootfs_label="fedora"`
		`@@ -34,7 +34,7 @@`
		`<preferences profiles="Cloud-Base-Vagrant-VirtualBox" arch="x86_64">`
		`<type image="oem" format="vagrant"`
		`filesystem="btrfs" btrfs_root_is_subvolume="true" btrfs_set_default_volume="false" fsmountoptions="compress=zstd:1"`
		`- kernelcmdline="no_timer_check console=tty1 console=ttyS0,115200n8 net.ifnames=0 biosdevname=0"`
		`+ kernelcmdline="no_timer_check console=tty1 console=ttyS0,115200n8"`
		`devicepersistency="by-uuid"`
		`bootpartition="true" bootpartsize="1000" bootfilesystem="ext4" efipartsize="100" firmware="uefi"`
		`rootfs_label="fedora"`

mhayden commented 2 months ago

Use consistent network device names for network devices instead of
forcing the old "ethX" names from pre-2017. This ensures that
specialized network devices, such as SR-IOV devices, are easy to
recognize and configure inside a Fedora instance on a public cloud or
OpenStack cloud.

FESCo ticket: https://pagure.io/fesco/issue/3190
Change proposal: https://fedoraproject.org/wiki/Changes/EnableConsistentDeviceNamingCloud

Signed-off-by: Major Hayden major@redhat.com

ngompa commented 2 months ago

What about the Vagrant cloud images?

mhayden commented 2 months ago

I'm happy to add those in, but that wasn't really in my original change. Let me know what you think.

zuul commented 2 months ago

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/c4b5dccf2ae340c59ced1a3b580186fe

build-images-x86_64 : SUCCESS in 11m 48s
build-images-aarch64 : SUCCESS in 13m 38s

ngompa commented 2 months ago

I would prefer we go ahead and change the Vagrant images too, since they are intended to be similar to the Cloud images.

rebased onto 3d861c6f246ba3d005a8132078ce70e07c5b3a59

2 months ago

mhayden commented 2 months ago

@ngompa Done!

zuul commented 2 months ago

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/8080879a1a334bcc980028a91dcdbb8b

build-images-x86_64 : SUCCESS in 11m 35s
build-images-aarch64 : SUCCESS in 12m 34s

ngompa commented 2 months ago

biosdevname=0 needs to be dropped too (it can do the same thing as net.ifnames=0).

adamwill commented 2 months ago

biosdevname does sort of the same thing, but with a different approach (it gives different names for the same interfaces, in the cases where both it and udev would rename the same interface). It doesn't work as broadly (and only works at all if the biosdevname package is installed, too). it's probably simpler, if you're doing this for the first time on cloud, to just stick to the systemd/udev approach and leave biosdevname off. the kernel arg is not necessary if you're not pulling in the package, though.

rebased onto 72083f7

2 months ago

mhayden commented 2 months ago

Thanks for the input! I've pushed a new patch.

zuul commented 2 months ago

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/717f7af7881d4cfc89b9be9e4222f557