#12 Logos for gnome-control-center
Closed 3 years ago by spot. Opened 3 years ago by catanzaro.

It would be nice to install logos that we could use in gnome-control-center.

  • pixmaps/fedora-logo.png looks great for this purpose in RHEL. But in Fedora, the logo is a different size and is too large. Also, there are no dark background variants.
  • fedora/fedora_logo.svg and fedora/fedora_logo_darkbackground.svg look good in both Fedora and RHEL, although there is a lot of whitespace around the edges of the SVG. However, gnome-control-center uses GtkImage, which does not support SVG.
  • I can easily convert fedora_logo.svg and fedora_logo_darkbackground.svg to a PNG to get a smaller variant with a dark background, but the result won't be the same as pixmaps/fedora-logo.png because of extra whitespace. I can crop it myself and try to come up with something that looks good, but I expect we have design folks who prefer to do this?
  • Alternative: currently we use fedora_vertical.png, which I add in the gnome-control-center RPM because it doesn't exist in fedora-logos at all. That could be added to fedora-logos.

I want to post some screenshots here... but it looks like uploading screenshots on pagure is broken?

References:


I can easily convert fedora_logo.svg and fedora_logo_darkbackground.svg to a PNG to get a smaller variant with a dark background, but the result won't be the same as pixmaps/fedora-logo.png because of extra whitespace. I can crop it myself and try to come up with something that looks good, but I expect we have design folks who prefer to do this?

For now, I'm going to do this, shrink them down to some arbitrary size that looks good to me, not bother with cropping it, and stick the logos directly in the gnome-control-center package. Can switch to official variants from fedora-logos whenever they exist.

I think thats... not a good idea at all.

First, the license here doesn't really give you a license to redistribute these logos in a seperate package.

Secondly, it would break all remixes... or at least they would have to know that there are logos in gnome-control-center that have to be replaced.

I think it's much better to try and get versions of the logos that you can work with in this package (and generic-logos).

I think it's much better to try and get versions of the logos that you can work with in this package (and generic-logos).

Well I agree, that's why I reported this issue. :P

First, the license here doesn't really give you a license to redistribute these logos in a seperate package.

Secondly, it would break all remixes... or at least they would have to know that there are logos in gnome-control-center that have to be replaced.

This is already the status quo since F32. We of course don't need a license from ourselves to use our own logos, but I see the point that it's no good for remixes. If you want, I can change it to just use the icon from /etc/os-release in F34. That goes against the design requirements from https://pagure.io/fedora-workstation/issue/135, but hopefully that could be addressed as part of this issue.

(and generic-logos).

I didn't know about this package. I agree hot dog logos are important!

OK, I wound up using fedora-logo-small.png (too small, but fedora-logo.png is just huge) and system-logo-white.png for dark mode (which looks dated and is obviously larger than fedora-logo-small.png, but better than nothing), both from fedora-logos. This isn't great, but it will do for now.

CC @duffy since I understand you're doing a bunch of work on fedora-logos at the moment. If you have time, would be good to address this too.

@catanzaro with my pull request merged yesterday, all of the logos in question have changed now.

i saw the mockups in the referenced tickets - i would strongly recommend usage of the horizontal format logo, the vertical one is really only meant for limited usage under more restrictive contexts than control-center appears to offer.

it is also really important as @nirik pointed out that we only package the logo in the fedora-logos packaging, so I am really happy to work with you to get something suitable in fedora-logos.

it seems like you need a PNG format, and you'd like both the full color one that works on a light background and a version that will work well on a dark background. I am happy to get those into fedora-logos for you. can you give me some ideal dimensions so I can export at the right size for you?

I am thinking pixmaps/fedora-logo.png is the right one, but if the previous one was too large for you the new one will probably be as well, so I can make a sized down version of that one both in color and a white version for dark backgrounds. I can do this right away if you can let me know the dimensions you'd prefer.

@catanzaro based on previous horizontal format mockups @aday put in the other ticket could i suggest this?

preview.png

This would involve a 254 x 73 px logo graphic, does that sound about right?

@duffy I think that size would work well! Certainly looks better than the too-small version that's there currently.

@aday remarked that the contrast seems pretty low. But changing that would require changing the color used for the logo itself, which I assume is not allowed.

CC @jimmac

@catanzaro thats right - we need to keep the horiz layout and blue color whenever possible.

Anyway it's your design, I'll update gnome-control-center to use the new logo files once you create them.

@catanzaro based on previous horizontal format mockups @aday put in the other ticket could i suggest this?

preview.png

This would involve a 254 x 73 px logo graphic, does that sound about right?

Can we go with this (at least for now?). Would be nice to be able to depend on these logos being installed. (We can always revise the graphics in later updates to fedora-logos if needed.)

yes i am working as fast as i can, i literally have it committed to my fork and had trouble with pagure letting me file the PR this morning and ive been in solid meetings / firefighting since then

(it's telling me i cant file a PR because the two repos contents are the same, am I dreaming?

https://pagure.io/fork/duffy/fedora-logos/commits/master
https://pagure.io/fedora-logos/commits/master)

And now it just started working, i have no clue but there we go, https://pagure.io/fedora-logos/pull-request/16

Metadata Update from @spot:
- Issue status updated to: Closed (was: Open)

3 years ago

Thanks @duffy!

Is there a separate version of the image for dark backgrounds, or do you want that image used regardless of background color?

@catanzaro it would be preferable to have it in white for dark backgrounds but I was unaware that was something that was needed so I didn't create that. I can file another pull request but @spot is already working on building everything :(

OK, I wound up using fedora-logo-small.png (too small, but fedora-logo.png is just huge) and system-logo-white.png for dark mode (which looks dated and is obviously larger than fedora-logo-small.png, but better than nothing), both from fedora-logos. This isn't great, but it will do for now.

Well I can continue to use system-logo-white.png in dark mode, but it's probably better to have a logo designed to be the same size as the new fedora_logo_med.png.

Anyway let me reopen this for now.

(BTW I notice the fedora-logos package hasn't been built yet.)

Metadata Update from @catanzaro:
- Issue status updated to: Open (was: Closed)

3 years ago

Hey @catanzaro we do actually have a build, it hasnt been pushed into the distro yet (hopefully today or tomorrow) adamw and I have been testing it and I am making some edits to the graphics based on the testing results.

We're being extremely cautious just because past fedora-logo change efforts have broken things really badly o_O

I see you uploaded a fedora_whitelogo_med.png. Thanks! I will use that for gnome-control-center, then.

That said, it looks like maybe something went wrong when creating this image as there is no visible 'f' character in the logo bubble, compared to the SVG version of the image which has a transparent 'f'.

Screenshot_from_2021-03-27_12-15-23.png

Got a bug report about it already. Anyway, other than that issue, I'm happy with these new logos. Thanks!

Mo, if you do a PR for that fix, I'll make a new update.

PR18 is merged, I have built new packages, and made a new update for Fedora34: https://bodhi.fedoraproject.org/updates/FEDORA-2021-2559a499ef

Metadata Update from @spot:
- Issue status updated to: Closed (was: Open)

3 years ago

Log in to comment on this ticket.

Metadata
Attachments 2