#54 blocking: Add a maximum size for Fedora-Container-Toolbox
Closed by rishi. Opened by rishi.

Now that the size problems for Fedora-Container-Toolbox have been fixed, we should consider adding a maximum size so that any inadvertent increase in size gets flagged.

Currently, registry.fedoraproject.org/fedora-toolbox:39 and registry.fedoraproject.org/fedora-toolbox:40 for x86_64 are approximately 360MB when downloading over the network. The aarch64 images are slightly smaller. You can check with:

$ skopeo --override-arch amd64 inspect --format "{{range .LayersData}}{{.Size}} {{end}}" docker://registry.fedoraproject.org/fedora-toolbox:40
362423527
$ skopeo --override-arch arm64 inspect --format "{{range .LayersData}}{{.Size}} {{end}}" docker://registry.fedoraproject.org/fedora-toolbox:40
336719653

However, the tarball produced by Image Factory looks a lot smaller. eg., looking at this scratch build, the ppc64le tarball is 170M and the x86_64 tarball is 188MB.

I don't know which of these sizes matter in this case.

I also don't know if we want the maximum size to be closer to the current sizes, or closer to the threshold where it really jumps at you.


Is this a request to update https://docs.fedoraproject.org/en-US/releases/f40/blocking/ ?

Is this a request to update https://docs.fedoraproject.org/en-US/releases/f40/blocking/ ?

Is this a request to update https://docs.fedoraproject.org/en-US/releases/f40/blocking/ ?

I am responding to your earlier question. :)

Is this a request to update https://docs.fedoraproject.org/en-US/releases/f40/blocking/ ?

I am responding to your earlier question. :)

Ping, @adamwill

I don't know which of these sizes matter in this case.

I can't submit a pull request without knowing this. However, anybody who knows the answer can also do it. It doesn't have to be me.

The size that matters for the Fedora release process is the size of the deliverable that's a part of the Fedora compose, i.e. https://kojipkgs.fedoraproject.org/compose/rawhide/Fedora-Rawhide-20240221.n.0/compose/Container/x86_64/images/Fedora-Container-Toolbox-Rawhide-20240221.n.0.x86_64.tar.xz , I guess. The maximum size should be "a size that thing really shouldn't reach, to the extent that if it does, you'll get a blocker bug filed and Adam will bug you about it".

The size that matters for the Fedora release process is the size of the deliverable that's a part of the Fedora compose, i.e. https://kojipkgs.fedoraproject.org/compose/rawhide/Fedora-Rawhide-20240221.n.0/compose/Container/x86_64/images/Fedora-Container-Toolbox-Rawhide-20240221.n.0.x86_64.tar.xz , I guess.

Ok, then, here we go: https://pagure.io/fedora-pgm/pgm_docs/pull-request/65

The maximum size should be "a size that thing really shouldn't reach, to the extent that if it does, you'll get a blocker bug filed and Adam will bug you about it".

Okay! Let's err on the side of paranoia like the Workstation image size limits to ensure that it's increasing for some good reason rather than due to packaging or build system bugs.

I wish we could have a minimum size limit too. Content can just as easily go missing. :)

Is there any need to add the maximum sizes for Fedora 39?

Is there more needed with this issue? Or shall I close now that the PR has been merged?

Is there more needed with this issue? Or shall I close now that the PR has been merged?

Yes, this can be closed now.

Metadata Update from @rishi:
- Issue status updated to: Closed (was: Open)

Metadata