#5 Make correction according to feedback.
Closed 4 years ago by lruzicka. Opened 4 years ago by lruzicka.

event_handler.py

  1. Handler should only be called by the Collector.
  2. Fix the behaviour of the stop_key to work if set on CLI.
  3. Use None instead of "not taken" for non-existent screenshot variables
  4. Archive older screenshots and do not delete them on start (unless specified on the command line)
  5. Shorten name_shot method to a one-liner.
  6. Use else instead of a new if statement on line 148.
  7. Get rid of the create_raw_reports method
  8. Fix the indentation on line 241 to make it more readable.
  9. Remove the stamp() method and use time.time() where needed.

Metadata Update from @lruzicka:
- Issue assigned to lruzicka

4 years ago

event_handler.py

Handler should only be called by the Collector.

Fixed.

Fix the behaviour of the stop_key to work if set on CLI.

The stop_key now works correctly. It also works as a start_key so the script will not record any events until the recording is switched on using the key. It will stop when pressing it for the second time.

Use None instead of "not taken" for non-existent screenshot variables

Fixed.

Shorten name_shot method to a one-liner.

Fixed.

Use else instead of a new if statement on line 148.

Fixed

Fix the indentation on line 241 to make it more readable.

Fixed

Remove the stamp() method and use time.time() where needed.

Fixed

The rest is coming.

The create_raw_report has been purged. -> FIXED

I believe, the event_handler.py has everything, the feedback asked for.

Metadata Update from @lruzicka:
- Issue status updated to: Closed (was: Open)

4 years ago

Log in to comment on this ticket.

Metadata