#390 modifying milestone through admin web interface generates http 500 errors
Closed: Fixed None Opened 11 years ago by tflink.

= bug description =

When changing a milestone through the web admin interface, saving changes generates a http 500 error with the following traceback:

{{{
Traceback (most recent call last):
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-packages/flask/app.py", line 1701, in call
return self.wsgi_app(environ, start_response)
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-packages/flask/app.py", line 1689, in wsgi_app
response = self.make_response(self.handle_exception(e))
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-packages/flask/app.py", line 1687, in wsgi_app
response = self.full_dispatch_request()
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-packages/flask/app.py", line 1360, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-packages/flask/app.py", line 1358, in full_dispatch_request
rv = self.dispatch_request()
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-packages/flask/app.py", line 1344, in dispatch_request
return self.view_functionsrule.endpoint
File "/home/tflink/code/blockerbugs/blockerbugs/controllers/users.py", line 95, in decorated_function
return f(args, *kwargs)
File "/home/tflink/code/blockerbugs/blockerbugs/controllers/admin.py", line 148, in modify_milestone
milestone.succeeds = selected_succeeds
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-packages/sqlalchemy/orm/attributes.py", line 155, in set
instance_dict(instance), value, None)
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-packages/sqlalchemy/orm/dynamic.py", line 117, in set
self.set_iterable(state, dict, value)
File "/home/tflink/code/blockerbugs/env_blockerbugs/lib/python2.7/site-packages/sqlalchemy/orm/dynamic.py", line 122, in _set_iterable
new_values = list(iterable)
TypeError: 'Milestone' object is not iterable
}}}

= fix recommendation =

Saving the milestone shouldn't tb and the save operation should complete successfully


pushed to master with 0d0af1f2fa6319186da673ba361c0e2d3521f900

pushed to devel with 2ec773fe395e9634eac468600944ef8229abf2b7

Works in local and dev host testing, waiting for package push to infra repo to test on staging before deployment to production

forgot to close this when it was pushed to production. It has been fixed for a while now

Log in to comment on this ticket.

Metadata