#438 Multiple builds fixing a bug show confusing status label
Closed: Fixed None Opened 11 years ago by kparal.

See the screenshot. There are two updates that claim to fix a single bug (that is correct, both of them are needed). One is stable, one is in testing. The BBA shows [stable] label. That is confusing, that seems to indicate that everything needed is in stable. (One might happen to visit that bug and close it, without inspecting it closer).

I think a better choice here is to show the "worst" status in the label. Therefore:

{{{
update X: stable
update Y: testing
-> label: [testing]

update X: stable
update Y: stable
-> label: [stable]

update X: pending testing
update Y: testing
-> label: [pending testing]

update X: pending stable
update Y: testing
-> label: [testing]

update X: stable
update Y: pending stable
-> label: [pending stable]
}}}

So, if you have an ordered array ['pending testing', 'testing', 'pending stable', 'stable'], you pick the lowest index available in update XYZ statuses and show that as the label.

What do you think?


multiple updates fixing a single bug
multifix.png

Replying to [ticket:438 kparal]:

So, if you have an ordered array ['pending testing', 'testing', 'pending stable', 'stable'], you pick the lowest index available in update XYZ statuses and show that as the label.

What do you think?

Correct. However, it turns out there are more issues with the update sync code that prevents this from being fixed easily (updates deleted from bodhi remain in the app's db as if they were not deleted...). I will investigate further.

Log in to comment on this ticket.

Metadata