There are several low disk-space conditions we may wish to trigger:
The 3rd one had been created[1] and the remains need to be added.
I've created another test case regarding to the 2nd condition.
*[1] https://fedoraproject.org/wiki/QA:Testcase_Preupgrade_low_/boot_space_to_download_install.img
Does it make sense to test cases in the 1st condition? Since in this case, we have to quit the preupgrade process and delete files in /boot to make the space at least enough to run the 2nd condition. Is there any tricky method to deal with this case?
This test seems appropriate to me given the current F-11 and F-12 limited disk space on ''/boot''. Also, I think the use case this test targets is sufficiently different from that of https://fedoraproject.org/wiki/QA:Testcase_Preupgrade_low_/boot_disk_space that it warrants it's own test.
I think the instructions you provided are a great start. I can't think of any corrections at this time.
Thanks for your reply, James. Since there isn't a distinct method to deal with the 1st condition, I think these two cases are enough for covering low /boot space conditions. What do you think?
Replying to [comment:3 rhe]:
I can see the utility of having tests for all 3 conditions. How would you feel about modifying the new test you've created to also test the ''no disk space available'' condition first? Meaning, you would 1. first fill up ''/boot'' with a dd command. 1. Run preupgrade ... it should fail. 1. Now, run dd command again but as you've specified (only taking up ~ 100 Mbs) 1. Run preupgrade ... it should probably recover from the previous failure 1. ... proceed with test case instructions as you've written ...
How's that?
Replying to [comment:4 jlaska]:
I can see the utility of having tests for all 3 conditions. How would you feel about modifying the new test you've created to also test the ''no disk space available'' condition first? Meaning, you would 1. first fill up ''/boot'' with a dd command. 1. Run preupgrade ... it should fail. 1. Now, run dd command again but as you've specified (only taking up ~ 100 Mbs) 1. Run preupgrade ... it should probably recover from the previous failure 1. ... proceed with test case instructions as you've written ... How's that?
I think it's a bit complex and confusing to write them in one test case. But yeah, that's the best idea so far to test all 3 conditions, so I updated the new case[1]. Do you think it's better now?
Looks good. I might reword step#2 slightly by doing ...
{{{ # dd if=/dev/zero of=/boot/preupgrade_filler bs=1M }}}
Also, I've made several wording corrections, and updated the test case description to describe the 2 failure scenarios being targeted with the test. Hopefully this doesn't alter your intent for the test (see [https://fedoraproject.org/w/index.php?title=QA%3ATestcase_Preupgrade_low_%2Fboot_space_to_download_install.img&diff=144090&oldid=144047 diff]).
Once you're happy with the changes, let's close this out. Nice work :)
Thanks for your corrections, James. It's much better now. I've modified the other low space case according to your changes on this one and also renamed these 2 cases as:
[http://fedoraproject.org/wiki/QA:Testcase_Preupgrade_low_/boot_disk_space_to_download QA:Testcase Preupgrade low /boot disk space to download][[BR]]
[http://fedoraproject.org/wiki/QA:Testcase_Preupgrade_low_/boot_disk_space_to_install QA:Testcase Preupgrade low /boot disk space to install][[BR]]
If you are happy with that, I'll just close this ticket. Thanks.
Metadata Update from @adamwill: - Issue untagged with: test review - Issue tagged with: test cases
Log in to comment on this ticket.