We use ramda.js in other projects. Change the code to use ramda.js instead of lodash.
Hi @lbrabec, I believe there's no alternative to uniqueId() in ramda. You can check this issue -> https://github.com/ramda/ramda/issues/1360. I think we should use any UUID package if that suffices our use-case or we can just have our own ID creator function.
uniqueId()
uniqid seems to be a good candidate, the project seems to be active and usage is basically the same as uniqueId() from lodash.
@lbrabec, Okay great! Let me move ahead with this one. I'll open a PR soon.
@lbrabec, I just checked out that it's not good to be used on the frontend. Should we consider this issue and move to use nanoid(https://github.com/adamhalasz/uniqid/issues/38)?
We can use nanoid and wrap under a custom function that can do the same thing as uniqueId()?
The function can be something like ->
import { nanoid } from 'nanoid'; const uniqueID = (string) => { return string + nanoid(); } console.log(uniqueID("OurText-"))
Good find, let's use nanoid.
@lbrabec Fixed in https://pagure.io/fedora-qa/landingpage/pull-request/17
fixed in 14f7971
Metadata Update from @lbrabec: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)