Added redirectable link to home-page in the file "NotFound.js"
Thanks for PR!
It seems that you used npm command to install dependencies instead of yarn and thus created package-lock.json (how yarn.lock got affected, I don't know). This change should contain just the change in src/NotFound.js.
npm
yarn
package-lock.json
yarn.lock
src/NotFound.js
Once this is resolved, I'll merge this PR.
3 new commits added
removed package-lock.json
Added home-page link to 404 page
I installed the dependencies using yarn and removed the package-lock.json file. Please check if that works.
Thanks, it works.
Could you please squash the commits into one?
2 new commits added
Merge branch 'master' of ssh://pagure.io/forks/nagaharshita/fedora-qa/landingpage
Added home page link to 404 page
rebased onto 947ed1b63f327f47be1cfcc041a4f31552475a78
1 new commit added
rebased onto e5545acee8f32ddc055c01190bf2b74184a8bb72
I did squash the commits to one.
Great!
Please rebase onto current master branch as it changed meanwhile. I added more tips to README.md. The tips should help you do it, if anything is unclear, feel free to ask.
master
add 'how to do pull requests' to README.md
@nagaharshita It seems like you mixed up the commits, maybe during the rebase? Please get the PR to a state where the base (aka the commit in git history just before any of your changes) is the current state of our master branch, and your changes are applied on top.
git history
If you are not that well versed with git (and given the very low complexity of the actual changes in the PR), you may consider saving your changes somewhere on the side, and starting with all the git stuff from scratch. Have a look at our README file for some tips on "how to work with git and pull requests".
Thanks
Yes, I mixed up the commits during rebase. I will do the git stuff from scratch as mentioned in the README file. Thanks for the guidance.
Pull-Request has been closed by nagaharshita
Added redirectable link to home-page in the file "NotFound.js"