fedora-qa / landingpage

#37 Removed redundancy in Blockers
Closed by lbrabec. Opened by emma50.
fedora-qa/ emma50/landingpage reduced_redundancy_in_blockers  into  master

Download 37.patch

Issue

https://pagure.io/fedora-qa/landingpage/issue/6

Changes

  • Created a functional component with the name final-stat to hold final table
  • Created another functional component with the name beta-stat to hold beta table
  • Converted blocker component from a class component to a functional component because the state in constructor function is redundant
  • Implemented ES6 object destructuring of props on final-stat, beta-stat and blocker component

This change didn't reduce the redundancy of code at all. Instead of having the same code twice in src/landingpage/Blockers.js, now there is the same code in two separate files src/landingpage/stats/BetaStat.js and src/landingpage/stats/FinalStat.js. One general component for both beta and final stats is a way to go here.

Metadata Update from @lbrabec:
- Pull-request tagged with: review in progress

Thank you for the review @lbrabec.
I'll make the changes now.

2 new commits added

  • Merge branch 'reduced_redundancy_in_blockers' of ssh://pagure.io/forks/emma50/fedora-qa/landingpage into reduced_redundancy_in_blockers
  • Merge branch 'reduced_redundancy_in_blockers' of ssh://pagure.io/forks/emma50/fedora-qa/landingpage into reduced_redundancy_in_blockers

Thanks for participating in contribution period of Outreachy. This pull-request has not been selected to be merged and will be closed for housecleaning purposes. We may revisit this pull-request later, but as of now we will focus on merging pull-requests from our accepted intern.

Pull-Request has been closed by lbrabec
Metadata
None

review in progress

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.