PR#112: Update comments: Ignore the ones made by Bodhi - fedora-qa/oraculum

fedora-qa / oraculum

#112 Update comments: Ignore the ones made by Bodhi

Merged 4 years ago by frantisekz. Opened 4 years ago by frantisekz.

bodhi_better_comments into master

Update comments: Ignore the ones made by Bodhi

František Zatloukal • 4 years ago

d9afbf2

oraculum/utils/bodhi.py

file modified

+1 -2

		`@@ -60,7 +60,6 @@`

		`return updates`

		`-`
		`def process_update(update):`
		`"""`
		`Cleans up single update dictionary to contain only data frontend needs`
		`@@ -77,7 +76,7 @@`
		`"url": update["url"],`
		`"status": "%s→%s" % (update["status"], update["request"]) if update["request"] else update["status"],`
		`"karma": update["karma"],`
		`- "comments": len(update["comments"])`
		`+ "comments": len([c for c in update["comments"] if c["user"]["name"] != "bodhi"])`
		`}`

tests/test_packager_dashboard_bodhi.py

file modified

+13 -5

		`@@ -59,8 +59,16 @@`
		`],`
		`"close_bugs": True,`
		`"comments": [`
		`- {},`
		`- {}`
		`+ {`
		`+ "user": {`
		`+ "name": "bodhi"`
		`+ }`
		`+ },`
		`+ {`
		`+ "user": {`
		`+ "name": "somebody"`
		`+ }`
		`+ }`
		`],`
		`"compose": None,`
		`"content_type": "rpm",`
		`@@ -193,7 +201,7 @@`
		`expected_result_single_package = {`
		`'gjs': [`
		`{`
		`- 'comments': 2,`
		`+ 'comments': 1,`
		`'karma': 2,`
		`'pretty_name': 'gjs-1.66.1-2.fc98',`
		`'release': 'Fedora 98',`
		`@@ -210,7 +218,7 @@`
		`expected_result_multiple_packages = {`
		`'gjs': [`
		`{`
		`- 'comments': 2,`
		`+ 'comments': 1,`
		`'karma': 2,`
		`'pretty_name': 'gjs-1.66.1-2.fc98 mozjs78-78.4.0-1.fc98',`
		`'release': 'Fedora 98',`
		`@@ -223,7 +231,7 @@`
		`],`
		`'mozjs78': [`
		`{`
		`- 'comments': 2,`
		`+ 'comments': 1,`
		`'karma': 2,`
		`'pretty_name': 'gjs-1.66.1-2.fc98 mozjs78-78.4.0-1.fc98',`
		`'release': 'Fedora 98',`

frantisekz commented 4 years ago

Fixes https://pagure.io/fedora-qa/packager_dashboard/issue/75

zuul commented 4 years ago

Build succeeded.

oraculum-pytest : SUCCESS in 1m 37s

jskladan commented on line 23 of oraculum/utils/bodhi.py 4 years ago

The same, but in one line:

return len([c for comments if c['user']['name'] != 'bodhi'])

Edited 4 years ago by jskladan

jskladan commented 4 years ago

Anyway, LGTM, do what you will with the comment above

rebased onto 731bc98

4 years ago

zuul commented 4 years ago

Build succeeded.

oraculum-pytest : SUCCESS in 1m 49s

Pull-Request has been merged by frantisekz

4 years ago

Metadata

Assignee

None

Tags

No Tags

Flags

Zuul

success

Jobs result is success

4 years ago

Changes Summary 2

+1 -2

file changed

oraculum/utils/bodhi.py

+13 -5

file changed

tests/test_packager_dashboard_bodhi.py

fedora-qa / oraculum

Source Code

#112 Update comments: Ignore the ones made by Bodhi Merged 4 years ago by frantisekz. Opened 4 years ago by frantisekz. bodhi_better_comments into master

Metadata

Flags

Changes Summary 2

#112 Update comments: Ignore the ones made by Bodhi

Merged 4 years ago by frantisekz. Opened 4 years ago by frantisekz.

bodhi_better_comments into master