#165 Add tests to resize LVM partitions (Blivet and Custom)
Merged 4 years ago by adamwill. Opened 4 years ago by lruzicka.

file modified
+2 -1
@@ -78,8 +78,9 @@ 

      testliterals.append(f"user_confirm_{user}")

  # partitioning stuff, there's a bunch of this, all in anaconda.pm

  # multiple things use this

- for part in ("swap", "root"):

+ for part in ("swap", "root", "efi", "boot"):

      testliterals.append(f"anaconda_part_select_{part}")

+     testliterals.append(f"anaconda_blivet_part_inactive_{part}")

  # select_disks

  for num in range(1, 10):

      testliterals.append(f"anaconda_install_destination_select_disk_{num}")

file modified
+47 -1
@@ -8,7 +8,7 @@ 

  use testapi;

  use utils;

  

- our @EXPORT = qw/select_disks custom_scheme_select custom_blivet_add_partition custom_change_type custom_change_fs custom_change_device custom_delete_part get_full_repo get_mirrorlist_url/;

+ our @EXPORT = qw/select_disks custom_scheme_select custom_blivet_add_partition custom_blivet_format_partition custom_blivet_resize_partition custom_change_type custom_change_fs custom_change_device custom_delete_part get_full_repo get_mirrorlist_url/;

  

  sub select_disks {

      # Handles disk selection. Has one optional argument - number of
@@ -174,6 +174,52 @@ 

      }

  }

  

+ sub custom_blivet_format_partition {

+     # This subroutine formats a selected partition. To use it, you must select the 

+     # partition by other means before you format it using this routine.

+     # You have to create a needle for any non-existing filesystem that is

+     # passed via the $type, such as anaconda_blivet_part_fs_ext4.

+     my %args = @_;

+     # Start editing the partition and select the Format option

+     assert_and_click "anaconda_blivet_part_edit";

+     assert_and_click "anaconda_blivet_part_format";

+     # Select the appropriate filesystem type.

+     assert_and_click "anaconda_blivet_part_drop_select";

+     assert_and_click "anaconda_blivet_part_fs_$args{type}";

+     wait_still_screen 2;

+     # Fill in the label if needed.

+     send_key "tab";

+     if ($args{label}) {

+         type_very_safely $args{label};

+     }

+     # Fill in the mountpoint.

+     send_key "tab";

+     type_very_safely $args{mountpoint};

+     assert_and_click "anaconda_blivet_part_format_button";

+ }

+ 

+ sub custom_blivet_resize_partition {

+     # This subroutine resizes the selected (active) partition to a given value. Note, that

+     # if the selected value is bigger than the available space, it will only be

+     # resized to fill up the available space no matter the number. 

+     # This routine cannot will not be able to select a particular partition!!!

+     my %args = @_;

+     # Start editing the partition and select the Resize option

+     assert_and_click "anaconda_blivet_part_edit";

+     assert_and_click "anaconda_blivet_part_resize";

+     # Select the appropriate units. Note, that there must a be needle existing

+     # for each possible unit that you might want to use, such as 

+     # "anaconda_blivet_size_unit_gib".

+     assert_and_click "anaconda_blivet_part_drop_select";

+     assert_and_click "anaconda_blivet_size_unit_$args{units}";

+     # Move back to the value field.

+     send_key "shift-tab";

+     # Type in the new size.

+     type_very_safely $args{size};

+     assert_and_click "anaconda_blivet_part_resize_button";

+ }

+ 

+ 

  sub custom_change_type {

      # Used to set different device types for specified partition (e.g.

      # RAID). Should be called when custom partitioning spoke is

@@ -0,0 +1,15 @@ 

+ {

+   "properties": [],

+   "tags": [

+     "anaconda_part_add"

+   ],

+   "area": [

+     {

+       "xpos": 22,

+       "ypos": 630,

+       "width": 53,

+       "height": 14,

+       "type": "match"

+     }

+   ]

+ } 

\ No newline at end of file

empty or binary file added
@@ -0,0 +1,15 @@ 

+ {

+   "properties": [],

+   "tags": [

+     "anaconda_part_add_mountpoint"

+   ],

+   "area": [

+     {

+       "xpos": 546,

+       "ypos": 479,

+       "width": 109,

+       "height": 17,

+       "type": "match"

+     }

+   ]

+ } 

\ No newline at end of file

empty or binary file added
@@ -0,0 +1,15 @@ 

+ {

+   "area": [

+     {

+       "xpos": 53,

+       "ypos": 285,

+       "width": 69,

+       "height": 18,

+       "type": "match"

+     }

+   ],

+   "properties": [],

+   "tags": [

+     "anaconda_part_select_efiboot"

+   ]

+ } 

\ No newline at end of file

@@ -0,0 +1,16 @@ 

+ {

+   "properties": [],

+   "tags": [

+     "anaconda_blivet_part_fs_select",

+     "anaconda_blivet_part_drop_select"

+   ],

+   "area": [

+     {

+       "xpos": 657,

+       "ypos": 313,

+       "width": 18,

+       "height": 15,

+       "type": "match"

+     }

+   ]

+ } 

\ No newline at end of file

@@ -0,0 +1,15 @@ 

+ {

+   "properties": [],

+   "tags": [

+     "anaconda_blivet_part_edit"

+   ],

+   "area": [

+     {

+       "xpos": 312,

+       "ypos": 247,

+       "width": 19,

+       "height": 19,

+       "type": "match"

+     }

+   ]

+ } 

\ No newline at end of file

@@ -0,0 +1,15 @@ 

+ {

+   "properties": [],

+   "tags": [

+     "anaconda_blivet_part_format"

+   ],

+   "area": [

+     {

+       "xpos": 329,

+       "ypos": 325,

+       "width": 56,

+       "height": 15,

+       "type": "match"

+     }

+   ]

+ } 

\ No newline at end of file

@@ -0,0 +1,15 @@ 

+ {

+   "properties": [],

+   "tags": [

+     "anaconda_blivet_part_format_button"

+   ],

+   "area": [

+     {

+       "xpos": 629,

+       "ypos": 496,

+       "width": 49,

+       "height": 16,

+       "type": "match"

+     }

+   ]

+ } 

\ No newline at end of file

@@ -0,0 +1,15 @@ 

+ {

+   "area": [

+     {

+       "xpos": 398,

+       "ypos": 295,

+       "width": 32,

+       "height": 20,

+       "type": "match"

+     }

+   ],

+   "properties": [],

+   "tags": [

+     "anaconda_blivet_part_fs_ext4"

+   ]

+ } 

\ No newline at end of file

@@ -0,0 +1,17 @@ 

+ {

+   "area": [

+     {

+       "xpos": 320,

+       "ypos": 419,

+       "type": "match",

+       "width": 171,

+       "height": 24

+     }

+   ],

+   "properties": [],

+   "tags": [

+     "LANGUAGE-english",

+     "anaconda_blivet_part_fs",

+     "anaconda_blivet_part_fs_ext4_selected"

+   ]

+ } 

\ No newline at end of file

@@ -0,0 +1,15 @@ 

+ {

+   "area": [

+     {

+       "xpos": 297,

+       "ypos": 329,

+       "width": 98,

+       "height": 19,

+       "type": "match"

+     }

+   ],

+   "properties": [],

+   "tags": [

+     "anaconda_blivet_part_inactive_boot"

+   ]

+ } 

\ No newline at end of file

@@ -0,0 +1,15 @@ 

+ {

+   "area": [

+     {

+       "width": 23,

+       "type": "match",

+       "height": 14,

+       "xpos": 710,

+       "ypos": 171

+     }

+   ],

+   "properties": [],

+   "tags": [

+     "anaconda_blivet_part_inactive_root"

+   ]

+ } 

\ No newline at end of file

@@ -0,0 +1,15 @@ 

+ {

+   "properties": [],

+   "tags": [

+     "anaconda_blivet_part_inactive_root"

+   ],

+   "area": [

+     {

+       "xpos": 581,

+       "ypos": 186,

+       "width": 23,

+       "height": 18,

+       "type": "match"

+     }

+   ]

+ } 

\ No newline at end of file

@@ -0,0 +1,15 @@ 

+ {

+   "properties": [],

+   "tags": [

+     "anaconda_blivet_part_resize"

+   ],

+   "area": [

+     {

+       "xpos": 331,

+       "ypos": 298,

+       "width": 43,

+       "height": 19,

+       "type": "match"

+     }

+   ]

+ } 

\ No newline at end of file

@@ -0,0 +1,15 @@ 

+ {

+   "properties": [],

+   "tags": [

+     "anaconda_blivet_part_resize_button"

+   ],

+   "area": [

+     {

+       "xpos": 718,

+       "ypos": 434,

+       "width": 41,

+       "height": 16,

+       "type": "match"

+     }

+   ]

+ } 

\ No newline at end of file

@@ -0,0 +1,16 @@ 

+ {

+   "area": [

+     {

+       "xpos": 714,

+       "ypos": 314,

+       "width": 28,

+       "height": 17,

+       "type": "match"

+     }

+   ],

+   "properties": [],

+   "tags": [

+     "anaconda_blivet_size_unit_gib",

+     "anaconda_blivet_size_unit_GiB"

+   ]

+ } 

\ No newline at end of file

needles/anaconda/partitioning/blivet/anaconda_blivet_size_unit_gib.png needles/anaconda/partitioning/blivet/anaconda_blivet_size_unit_mib-20200116.png
file renamed
file was moved with no change to the file
needles/anaconda/partitioning/blivet/anaconda_blivet_size_unit_mib.json needles/anaconda/partitioning/blivet/anaconda_blivet_size_unit_mib-20200116.json
file renamed
file was moved with no change to the file
@@ -0,0 +1,15 @@ 

+ {

+   "properties": [],

+   "tags": [

+     "anaconda_part_device_reformat"

+   ],

+   "area": [

+     {

+       "xpos": 614,

+       "ypos": 386,

+       "width": 80,

+       "height": 19,

+       "type": "match"

+     }

+   ]

+ } 

\ No newline at end of file

empty or binary file added
@@ -0,0 +1,15 @@ 

+ {

+   "properties": [],

+   "tags": [

+     "anaconda_part_mountpoint_selected"

+   ],

+   "area": [

+     {

+       "xpos": 501,

+       "ypos": 152,

+       "width": 87,

+       "height": 25,

+       "type": "match"

+     }

+   ]

+ } 

\ No newline at end of file

empty or binary file added
@@ -0,0 +1,15 @@ 

+ {

+   "properties": [],

+   "tags": [

+     "anaconda_part_select_boot"

+   ],

+   "area": [

+     {

+       "xpos": 53,

+       "ypos": 434,

+       "width": 44,

+       "height": 18,

+       "type": "match"

+     }

+   ]

+ } 

\ No newline at end of file

empty or binary file added
@@ -0,0 +1,15 @@ 

+ {

+   "properties": [],

+   "tags": [

+     "anaconda_part_use_current"

+   ],

+   "area": [

+     {

+       "xpos": 29,

+       "ypos": 347,

+       "width": 108,

+       "height": 18,

+       "type": "match"

+     }

+   ]

+ } 

\ No newline at end of file

empty or binary file added
file modified
+28 -1
@@ -260,7 +260,7 @@ 

              "flavor": "Workstation-live-iso",

              "settings": {

                  "DESKTOP": "gnome",

-                 "HDDSIZEGB": "13",

+                 "HDDSIZEGB": "20",

                  "LIVE": "1",

                  "PACKAGE_SET": "default",

                  "TEST_TARGET": "ISO"
@@ -273,6 +273,7 @@ 

              "flavor": "Workstation-live-iso",

              "settings": {

                  "DESKTOP": "gnome",

+                 "HDDSIZEGB": "20",

                  "LIVE": "1",

                  "PACKAGE_SET": "default",

                  "TEST_TARGET": "ISO"
@@ -622,6 +623,32 @@ 

                  "START_AFTER_TEST": "install_default_upload"

              }

          },

+         "install_blivet_resize_lvm": {

+             "profiles": {

+                 "fedora-Workstation-live-iso-x86_64-*-64bit": 30,

+                 "fedora-Workstation-live-iso-ppc64le-*-ppc64le": 30

+             },

+             "settings": {

+                 "PARTITIONING": "custom_blivet_resize_lvm",

+                 "HDD_1": "disk_%FLAVOR%_%MACHINE%.qcow2",

+                 "ROOT_PASSWORD": "weakpassword",

+                 "START_AFTER_TEST": "install_default_upload",

+                 "INSTALL": "1"

+             }

+         },

+         "install_resize_lvm": {

+             "profiles": {

+                 "fedora-Workstation-live-iso-x86_64-*-64bit": 30,

+                 "fedora-Workstation-live-iso-ppc64le-*-ppc64le": 30

+             },

+             "settings": {

+                 "PARTITIONING": "custom_resize_lvm",

+                 "START_AFTER_TEST": "install_default_upload",

+                 "HDD_1": "disk_%FLAVOR%_%MACHINE%.qcow2",

+                 "INSTALL": "1",

+                 "ROOT_PASSWORD": "weakpassword"

+             }

+         },

          "desktop_browser": {

              "profiles": {

                  "fedora-KDE-live-iso-x86_64-*-64bit": 22,

@@ -0,0 +1,84 @@ 

+ use base "anacondatest";

+ use strict;

+ use testapi;

+ use anaconda;

+ use utils;

+ 

+ sub activate {

+     # This subroutine activates a partition in Blivet environment.

+     # Due to some failures on different architectures, probably caused by their

+     # slowliness, we will need to do the partition activation proces several

+     # times to make sure the proper partition gets activated.

+     my $partition = shift;

+     my $count = 12;

+     while (check_screen "anaconda_blivet_part_inactive_$partition" and $count > 0) {

+         assert_and_click "anaconda_blivet_part_inactive_$partition";

+         sleep 5;

+         $count -= 1;

+     }

+ }

+ 

+ sub run {

+     my $self = shift;

+     # Navigate to "Installation destionation" and select blivet-gui 

+     # to manipulate the partitions. This will be automatically

+     # done using the following method, because PARTITIONING starts

+     # with "custom_blivet".

+     select_disks();

+     assert_and_click "anaconda_spoke_done";

+ 

+     # The following procedure will use Blivet to resize the root partition from

+     # a previous Linux installation and prepare the disk for new installation

+     # which will be then followed through.

+ 

+     # Partitioning starts out of the LVM on VD1. We will use it to recreate

+     # the "/boot" partition in there. In UEFI, we will need to deal with the /boot/efi

+     # partition first.

+     if (get_var("UEFI") == 1) {

+         #The efi partition should be already activated. So reformat it and remount.

+         custom_blivet_format_partition(type => 'efi_filesystem', label => 'efiboot', mountpoint => '/boot/efi');

+         wait_still_screen 5;

+     }

+ 

+     # Select the boot partition and reformat it and remount.

+     activate("boot");

+     # Boot is the only ext4 partition on that scheme, so we will use that to make a needle.

+     wait_still_screen 5;

+     custom_blivet_format_partition(type => 'ext4', label => 'boot', mountpoint => '/boot');

+     wait_still_screen 5;

+ 

+     # Select the LVM root partition, resize it, and format it.

+     assert_and_click "anaconda_blivet_volumes_icon";

+     wait_still_screen 5;

+     # Activate root partition if not active already

+     activate("root");

+     custom_blivet_resize_partition(size => '13', units => 'GiB');

+     wait_still_screen 5;

+ 

+     # Now format the resized root partition. It seems that the focus returns to the first

+     # partition in the view, so we need to activate this again before we attempt to do 

+     # anything to the partition.

+     activate("root");

+     custom_blivet_format_partition(type => 'ext4', label => 'root', mountpoint => '/');

+     wait_still_screen 5;

+ 

+     # Select the newly created free space

+     assert_and_click "anaconda_blivet_free_space";

+ 

+     # Create a partition and format it.

+     custom_blivet_add_partition(filesystem => 'ext4', mountpoint => '/home');

+     wait_still_screen 5;

+ 

+     # Close the spoke.

+     assert_and_click "anaconda_spoke_done";

+     wait_still_screen 5;

+ 

+     # Confirm changes

+     assert_and_click "anaconda_part_accept_changes";

+ }

+ 

+ sub test_flags {

+         return { fatal => 1 };

+ }

+ 

+ 1;

@@ -0,0 +1,92 @@ 

+ use base "anacondatest";

+ use strict;

+ use testapi;

+ use anaconda;

+ use utils;

+ 

+ sub goto_mountpoint {

+     my $counter = 20;

+     while (!check_screen "anaconda_part_mountpoint_selected" and $counter > 0) {

+         send_key "tab";

+         $counter += 1;

+         sleep 1;

+     }

+ }

+ 

+ sub run {

+     my $self = shift;

+     # Navigate to "Installation destionation" and select blivet-gui 

+     # to manipulate the partitions. This will be automatically

+     # done using the following method, because PARTITIONING starts

+     # with "custom_blivet".

+     select_disks();

+     assert_and_click "anaconda_spoke_done";

+ 

+     # The following procedure will use Custom Partitioning to resize the root partition from

+     # a previous Linux installation and prepare the disk for new installation

+     # which will be then followed through.

+ 

+     # Custom partitioning shows that an existing installations is there on the disk, 

+     # we need to select it to proceed.

+     assert_and_click "anaconda_part_use_current";

+ 

+     # At first, we will recreate the /boot mountpoint in the existing installation

+     # and reformat it.

+     #

+     assert_and_click "anaconda_part_select_boot";

+     # navigate to "Mountpoint"

+     goto_mountpoint();

+     type_very_safely "/boot";

+     assert_and_click "anaconda_part_device_reformat";

+     assert_and_click "anaconda_part_update_settings";

+ 

+     # For UEFI based images, we need to reassign the efi boot

+     # mountpoint as well

+     if (get_var("UEFI") == 1) {

+         assert_and_click "anaconda_part_select_efiboot";

+         goto_mountpoint();

+         type_very_safely "/boot/efi";

+         assert_and_click "anaconda_part_device_reformat";

+         assert_and_click "anaconda_part_update_settings";

+     }

+ 

+     # Now resize and format the current root partition

+     assert_and_click "anaconda_part_select_root";

+     # Navigate to Mountpoint

+     goto_mountpoint();

+     type_very_safely "/";

+     # Skip to the Size window

+     send_key "tab";

+     type_very_safely "13 GiB";

+     # Reformat and update the partition

+     assert_and_click "anaconda_part_device_reformat";

+     assert_and_click "anaconda_part_update_settings";

+ 

+     # Add new /home partition into the emptied space.

+     assert_and_click "anaconda_part_add";

+ 

+     # The previous step brings us into a mountpoint field

+     # of the pop-up window, so we only need to fill the value in.

+     # Also, it seems that leaving the size field empty automatically

+     # suggests to use the remaining free space.

+     type_very_safely "/home";

+     send_key "tab";

+     assert_and_click "anaconda_part_add_mountpoint";

+ 

+     # Then mount the Swap partition.

+     assert_and_click "anaconda_part_select_swap";

+     assert_and_click "anaconda_part_device_reformat";

+     assert_and_click "anaconda_part_update_settings";

+ 

+     # Close the spoke.

+     assert_and_click "anaconda_spoke_done";

+ 

+     # Confirm changes

+     assert_and_click "anaconda_part_accept_changes";

+ }

+ 

+ sub test_flags {

+         return { fatal => 1 };

+ }

+ 

+ 1;

This PR adds partitioning tests for Blivet and Custom Partitioning that works on the LVM setup and fixes #160.

This PR:

  • creates a Blivet test that takes an old installation, squeezes the root partition, adds a new home partition in its place and installs another system Fedora WS Live onto it.
  • creates a Custom partitioning test that does the same.
  • adds these tests as a start_after_test into the Workstation product (Workstation uses LVM as default and such resizing scenario is likely to happen there)
  • increases the disk size of the install_default_upload image for Workstation Live to 20 GiB (it was 10 before).
  • adds another install_default_upload for WS Live running on a UEFI machine which is used by the UEFI versions of the above tests.
  • removes the install_default running on UEFI, because it would only copy the actions of the above.

Currently, both tests pass in Staging for x86_64 in both BIOS and UEFI versions: https://openqa.stg.fedoraproject.org/tests/overview?distri=fedora&version=Rawhide&build=Fedora-Rawhide-20200525.n.0&groupid=1

Build failed.

1 new commit added

  • Whitelist not recognized needles in check-needles.py
4 years ago

I believe that unused needles originate from calls similar to this one "anaconda_blivet_part_inactive_$partition"` that the script did not recognize. I have whitelisted them.

Build succeeded.

This seems like a debug thing that could be dropped now?

Thanks!

So, some thoughts:

  1. I think I'd prefer if the test were called install_shrink_lvm, to more closely align with the existing shrink tests.
  2. I am a little unsure about whether we really need the UEFI variant of the test. We don't have UEFI variants of the other shrink tests. What's the intent there, exactly?
  3. Please make sure needle file names and tags match. There are needle files anaconda_blivet_part_root_inactive-20200514.json and anaconda_blivet_part_root_inactive.json with the tag anaconda_blivet_part_inactive_root. The filenames should be adjusted to match the tag. Also, why do we need two variants of that needle?
  4. Are the part_select_(fs) needles not just dupes of the existing part_fs_(fs) needles?
  5. The filenames of the needle mounpoint_selected.json are typoed (missing a "t").

I think I'd prefer if the test were called install_shrink_lvm, to more closely align with the existing shrink tests.

Yeah, I do not see a problem here. I chose the name because I thought it was closer to other disk_custom_blivet_... tests.

I am a little unsure about whether we really need the UEFI variant of the test. We don't have UEFI variants of the other shrink tests. What's the intent there, exactly?

Well, for the uefi variant you have count with the uefi boot partition, but if you are ok with just testing the shrinking on a normal image, let's do it and save some space.

Please make sure needle file names and tags match. There are needle files anaconda_blivet_part_root_inactive-20200514.json and anaconda_blivet_part_root_inactive.json with the tag anaconda_blivet_part_inactive_root. The filenames should be adjusted to match the tag.

Sure.

Also, why do we need two variants of that needle?

In staging, the test choke on that needle, so I recreated it and left the old one to make sure it won't fail again (wasn't sure if it was just a glitch, or some iso thing). I can delete one of them.

Are the part_select_(fs) needles not just dupes of the existing part_fs_(fs) needles?

I will check.

The filenames of the needle mounpoint_selected.json are typoed (missing a "t").

I will fix that.

Thanks for the comments.

This seems like a debug thing that could be dropped now?

Yeah, it is a debug thing :rabbit:

3 new commits added

  • Rename needle to correct typo.
  • Rename needles to match the tag.
  • Delete debug print.
4 years ago

Build succeeded.

Adam, I found a reason why it is good that the tests are named as they are now, because they basically are not just simple shrink tests. The LVM cannot be shrunk the way the shrink tests work. These are more about the partitioning, too (that's what they originate from) and they get nicely loaded by the Disk partitioning section in main.py.

However, if you instisted, I could probably change the loading mechanism to something like ENTRYPOINT or something.

Do you want to discard the UEFI testing, too?

Please, let me know.

1 new commit added

  • Use existing needles for fs selection.
4 years ago

rebased onto 5ffa8a421cf8e7359eaf6d8d86660c70c4183d82

4 years ago

Build succeeded.

I think we can drop 'ext4' here now, can't we?

the needle name in this comment now needs changing.

As for the test name: we're just sort of thinking about things from different angles, here. You're thinking about how the test is implemented and figuring "it's implemented like the other custom partitioning tests so it should be named like them". I'm thinking about what the test is intended to test and basing the name on that.

How about install_resize_lvm? The main concern for me is that just install_resize doesn't accurately convey that the test is specifically about LVM...

On UEFI: I guess it's true that we wind up testing reformat of the EFI system partition there. But that's not what this test sets out to do, and it's fairly unlikely that reformatting /boot would work but reformatting the ESP would fail. So I think on the whole we can just drop the UEFI test...

rebased onto 9efb0e1

4 years ago

Build succeeded.

1 new commit added

  • Finish the post review changes.
4 years ago

Build succeeded.

1 new commit added

  • Fix an error in test distribution.
4 years ago

Build succeeded.

10 new commits added

  • Fix an error in test distribution.
  • Finish the post review changes.
  • Use existing needles for fs selection.
  • Rename needle to correct typo.
  • Rename needles to match the tag.
  • Delete debug print.
  • Whitelist not recognized needles in check-needles.py
  • Add to templates.
  • Create a test for resizing using custom partitioning
  • Create a test to resize LVM partitions using Blivet.
4 years ago

Build succeeded.

10 new commits added

  • Fix an error in test distribution.
  • Finish the post review changes.
  • Use existing needles for fs selection.
  • Rename needle to correct typo.
  • Rename needles to match the tag.
  • Delete debug print.
  • Whitelist not recognized needles in check-needles.py
  • Add to templates.
  • Create a test for resizing using custom partitioning
  • Create a test to resize LVM partitions using Blivet.
4 years ago

Build succeeded.

1 new commit added

  • Run resize tests on Server DVD not Workstation live
4 years ago

Build succeeded.

OK, thanks for the changes.

Looking at this again I kinda feel weird about it being a Workstation live test. It just feels odd. Also Workstation live doesn't exist for aarch64 and has been broken for over a month on ppc64le. But the alternatives aren't great either, at least ones I can think of:

  1. Use Everything-boot-iso instead
  2. Use Server-dvd-iso instead
  3. Add an install_lvm_upload or something to universal, use that
  4. Write "install to LVM; reboot to installer; resize installed system and install again; boot to installed system" as a single test

1 and 3 add entirely new uploaded disk images, which eat more space on staging than using an existing one (even if we make it bigger). 2 doesn't work because Server's default filesystem is xfs and we can't resize xfs (I tried and it broke on this). 4 is difficult because it would involve re-attaching the installer disc after the first install has completed, and I'm not sure we can do that; even if we can work around that it doesn't feel too great as a solution either.

So...I guess we can just go with this. At least for now.

10 new commits added

  • Fix an error in test distribution.
  • Finish the post review changes.
  • Use existing needles for fs selection.
  • Rename needle to correct typo.
  • Rename needles to match the tag.
  • Delete debug print.
  • Whitelist not recognized needles in check-needles.py
  • Add to templates.
  • Create a test for resizing using custom partitioning
  • Create a test to resize LVM partitions using Blivet.
4 years ago

Build succeeded.

10 new commits added

  • Fix an error in test distribution.
  • Finish the post review changes.
  • Use existing needles for fs selection.
  • Rename needle to correct typo.
  • Rename needles to match the tag.
  • Delete debug print.
  • Whitelist not recognized needles in check-needles.py
  • Add to templates.
  • Create a test for resizing using custom partitioning
  • Create a test to resize LVM partitions using Blivet.
4 years ago

Build succeeded.

Pull-Request has been merged by adamwill

4 years ago
Metadata
Changes Summary 45
+2 -1
file changed
check-needles.py
+47 -1
file changed
lib/anaconda.pm
+15
file added
needles/anaconda/partitioning/add.json
+0
file added
needles/anaconda/partitioning/add.png
+15
file added
needles/anaconda/partitioning/add_mountpoint.json
+0
file added
needles/anaconda/partitioning/add_mountpoint.png
+15
file added
needles/anaconda/partitioning/anaconda_part_select_efiboot.json
+0
file added
needles/anaconda/partitioning/anaconda_part_select_efiboot.png
+16
file added
needles/anaconda/partitioning/blivet/anaconda_blivet_part_drop_select.json
+0
file added
needles/anaconda/partitioning/blivet/anaconda_blivet_part_drop_select.png
+15
file added
needles/anaconda/partitioning/blivet/anaconda_blivet_part_edit.json
+0
file added
needles/anaconda/partitioning/blivet/anaconda_blivet_part_edit.png
+15
file added
needles/anaconda/partitioning/blivet/anaconda_blivet_part_format.json
+0
file added
needles/anaconda/partitioning/blivet/anaconda_blivet_part_format.png
+15
file added
needles/anaconda/partitioning/blivet/anaconda_blivet_part_format_button.json
+0
file added
needles/anaconda/partitioning/blivet/anaconda_blivet_part_format_button.png
+15
file added
needles/anaconda/partitioning/blivet/anaconda_blivet_part_fs_ext4.json
+0
file added
needles/anaconda/partitioning/blivet/anaconda_blivet_part_fs_ext4.png
+17
file added
needles/anaconda/partitioning/blivet/anaconda_blivet_part_fs_ext4_selected-20200507.json
+0
file added
needles/anaconda/partitioning/blivet/anaconda_blivet_part_fs_ext4_selected-20200507.png
+15
file added
needles/anaconda/partitioning/blivet/anaconda_blivet_part_inactive_boot.json
+0
file added
needles/anaconda/partitioning/blivet/anaconda_blivet_part_inactive_boot.png
+15
file added
needles/anaconda/partitioning/blivet/anaconda_blivet_part_inactive_root-20200514.json
+0
file added
needles/anaconda/partitioning/blivet/anaconda_blivet_part_inactive_root-20200514.png
+15
file added
needles/anaconda/partitioning/blivet/anaconda_blivet_part_inactive_root.json
+0
file added
needles/anaconda/partitioning/blivet/anaconda_blivet_part_inactive_root.png
+15
file added
needles/anaconda/partitioning/blivet/anaconda_blivet_part_resize.json
+0
file added
needles/anaconda/partitioning/blivet/anaconda_blivet_part_resize.png
+15
file added
needles/anaconda/partitioning/blivet/anaconda_blivet_part_resize_button.json
+0
file added
needles/anaconda/partitioning/blivet/anaconda_blivet_part_resize_button.png
+16
file added
needles/anaconda/partitioning/blivet/anaconda_blivet_size_unit_gib.json
+0 -0
file renamed
needles/anaconda/partitioning/blivet/anaconda_blivet_size_unit_mib-20200116.png
needles/anaconda/partitioning/blivet/anaconda_blivet_size_unit_gib.png
+0 -0
file renamed
needles/anaconda/partitioning/blivet/anaconda_blivet_size_unit_mib-20200116.json
needles/anaconda/partitioning/blivet/anaconda_blivet_size_unit_mib.json
+0
file added
needles/anaconda/partitioning/blivet/anaconda_blivet_size_unit_mib.png
+15
file added
needles/anaconda/partitioning/device_reformat.json
+0
file added
needles/anaconda/partitioning/device_reformat.png
+15
file added
needles/anaconda/partitioning/mountpoint_selected.json
+0
file added
needles/anaconda/partitioning/mountpoint_selected.png
+15
file added
needles/anaconda/partitioning/select_boot.json
+0
file added
needles/anaconda/partitioning/select_boot.png
+15
file added
needles/anaconda/partitioning/use_current.json
+0
file added
needles/anaconda/partitioning/use_current.png
+28 -1
file changed
templates.fif.json
+84
file added
tests/disk_custom_blivet_resize_lvm.pm
+92
file added
tests/disk_custom_resize_lvm.pm