PR#176: Automate QA:Testcase_RpmOstree_Package_Layering - fedora-qa/os-autoinst-distri-fedora

fedora-qa / os-autoinst-distri-fedora

#176 Automate QA:Testcase_RpmOstree_Package_Layering

Merged 4 years ago by adamwill. Opened 4 years ago by lruzicka.

iot-rpmostree-overlay into master

Automate the IoT rpm-ostree package layering test case.

Lukáš Růžička • 4 years ago

8c40583

templates.fif.json

file modified

+13

		`@@ -1505,6 +1505,19 @@`
		`"START_AFTER_TEST": "install_default_upload"`
		`}`
		`},`
		`+ "iot_rpmostree_overlay": {`
		`+ "profiles": {`
		`+ "fedora-IoT-dvd_ostree-iso-aarch64-*-aarch64": 20,`
		`+ "fedora-IoT-dvd_ostree-iso-x86_64-*-64bit": 20`
		`+ },`
		`+ "settings": {`
		`+ "BOOTFROM": "c",`
		`+ "HDD_1": "disk_%FLAVOR%_%MACHINE%.qcow2",`
		`+ "POSTINSTALL": "iot_rpmostree_overlay",`
		`+ "ROOT_PASSWORD": "weakpassword",`
		`+ "START_AFTER_TEST": "install_default_upload"`
		`+ }`
		`+ },`
		`"mediakit_fileconflicts": {`
		`"profiles": {`
		`"fedora-Server-dvd-iso-aarch64-*-aarch64": 10,`

tests/iot_rpmostree_overlay.pm

file added

+81

		`@@ -0,0 +1,81 @@`
		`+ use base "installedtest";`
		`+ use strict;`
		`+ use testapi;`
		`+ use utils;`
		`+`
		`+ sub reboot_and_login {`
		`+ # This subroutine reboots the host, waits out the boot process and logs in.`
		`+ my $reboot_time = shift;`
		`+ script_run "systemctl reboot";`
		`+ boot_to_login_screen(timeout => $reboot_time);`
		`+ console_login(user=>"root", password=>get_var("ROOT_PASSWORD"));`
		`+ sleep 2;`
		`+ }`
		`+`
		`+ sub run {`
		`+ my $self = shift;`
		`+ my $reboot_time = 300;`
		`+ # switch to TTY3 for both, graphical and console tests`
		`+ $self->root_console(tty=>3);`
		`+`
		`+ # Install wget as rpm-ostree overlay. Let's have timeout defined`
		`+ # quite generously, because it loads the package DBs.`
		`+ assert_script_run "rpm-ostree install wget", timeout => 300;`
		`+ # Reboot the machine to boot into the overlayed tree.`
		`+ reboot_and_login "300";`
		`+`
		`+ # Check that wget rpm is installed`
		`+ assert_script_run "rpm -q wget";`
		`+ # And that it works`
		`+ assert_script_run "wget --version";`
		`+`
		`+ # Then install the httpd package.`
		`+ assert_script_run "rpm-ostree install httpd", timeout => 300;`
		`+`
		`+ # Reboot the machine to boot into the overlayed tree.`
		`+ reboot_and_login "300";`
		`+`
		`+ # Check for new as well as old overlays`
		`+ assert_script_run "rpm -q wget";`
		`+ assert_script_run "rpm -q httpd";`
		`+ assert_script_run "rpm -q apr";`
		`+`
		`+ # Start the httpd.service and check for its status`
		`+ assert_script_run "systemctl start httpd";`
		`+ assert_script_run "systemctl is-active httpd";`
		`+`
		`+ # Check for the functional test page`
		`+ assert_script_run "curl -o page.html http://localhost";`
		`+ assert_script_run "grep 'Fedora Project' page.html";`
		`+`
		`+ # Enable the httpd service`
		`+ assert_script_run "systemctl enable httpd";`
		`+`
		`+ # Reboot the computer to boot check if the service has been enabled and starts`
		`+ # automatically.`
		`+ reboot_and_login "300";`
		`+`
		`+ # See if httpd is started`
		`+ assert_script_run "systemctl is-active httpd";`
		`+`
		`+ # Uninstall wget and httpd again.`
		`+ assert_script_run "rpm-ostree uninstall wget httpd";`
		`+`
		`+ # Reboot to see the changed tree`
		`+ reboot_and_login "300";`
		`+`
		`+ # Check if wget and httpd were removed and no longer can be used.`
		`+ assert_script_run "! rpm -q wget";`
		`+ assert_script_run "! rpm -q httpd";`
		`+ assert_script_run "! wget --version";`
		`+ assert_script_run "! systemctl is-active httpd";`
		`+`
		`+ }`
		`+`
		`+ sub test_flags {`
		`+ return { fatal => 1 };`
		`+ }`
		`+`
		`+ 1;`
		`+`
		`+ # vim: set sw=4 et:`

lruzicka commented 4 years ago

This test tests that rpms could be layered using os-tree in IoT and FIXES #168.

1 new commit added

Add to templates.

4 years ago

zuul commented 4 years ago

Build succeeded.

os-autoinst-tox : SUCCESS in 2m 15s
os-autoinst-perl : SUCCESS in 4m 10s

lruzicka commented 4 years ago

I tested this PR on Fedora IoT 32, because due to a bug (https://bugzilla.redhat.com/show_bug.cgi?id=1838691), this cannot be tested on Fedora IoT Rawhide yet.

adamwill commented on line 50 of tests/iot_rpmostree_overlay.pm 4 years ago

grep 'Fedora Project' page.html works fine, you know :D

adamwill commented on line 46 of tests/iot_rpmostree_overlay.pm 4 years ago

there's a systemctl is-active you can use here which should be safer than relying on the output of systemctl status. See the base_service_manipulation.pm test for examples.

adamwill commented on line 60 of tests/iot_rpmostree_overlay.pm 4 years ago

systemctl is-active here again.

adamwill commented on line 73 of tests/iot_rpmostree_overlay.pm 4 years ago

all the above can be improved with the handy bash-ism !, I believe. try e.g. assert_script_run "! rpm -q wget". this will be particularly handy for the last two, because as things stand they are not actually testing anything.

adamwill commented 4 years ago

can you address the line-by-line comments and squash this down to a single commit? thanks!