In this PR:

• some needles were recreated to match different locations and new icons
• Evolution test was deleted due to removal of the application.
• Some tests were changed in order to cope with some icons being moved to Utilities subgroup.

I don't understand why there need to be new variants of needles like 'apps_menu_dviewer', 'apps_menu_archiver' etc. From an eyeball look at least, nothing has changed about the icons for these apps; do the old needles really no longer match?

I do not understand, what you mean exactly. The Archiver has a totally different icon, for example. I am not sure about Document Viewer, it looked a bit more polished to me when I was trying to fix the test case, however now, after a closer look, it perhaps does not differ, so this one needle might not be necessary.

I kept those old needles there for backward compatibility with early stages of Rawhide, when it still resembled the 29 release. When inspecting other tests, I had the notion that for some tags, we also have different needles (usually named with dates).

If the icon has actually changed and the old needle doesn't match any more, it's fine - but I wanted to be clear that's the case. Generally speaking, you only ever need to replace or add a needle if there's a case where it should match, but does not.

We have lots of 'variant' needles indeed, but only where there's a need - where a test started failing because a needle stopped matching, basically. My usual practice is to keep the old needle around at least at first unless we're absolutely sure there'd be no situation where it might be useful. We commonly do actually need more than one variant of a needle at a time, because we use many of them on different releases - there's Branched and Rawhide, then the stable tests that run on stable releases, and the upgrade tests which start out on a stable release (and may need to go through graphical login).

I then usually go through the needles once a year and clean up old ones that we are no longer using (there are some features that help with this in the admin UI).

So, basically, I just want to be clear that there's a specific need for the new needles - that the test fails on Rawhide with the old needles.

Oh, also, arguably the 'add new needles' change should be a separate commit from the 'fix for removal of app menu' change, since they're not really the same thing at all, I think...

Oh, I did not know that in this situation two commits are better than one. Usually, you want me to squash the commits. I thought that the task was to make that test work again and when I was changing the needles to match different spots in the applications, I realized there were like two or three bad needles which needed to be recreated for the test to work, so I did it in one batch.

With this test, we will have to recreate most of the needles in near future anyway, when they change the icons for more modern ones.

I will check, if the old Documents Viewer needle works ... if so I will delete the new one, but otherwise I believe that the addition was needed.

So the general rule for commits is that each change that kinda 'stands alone' should be a single commit. If you're basically trying to do one thing - like "add a new test for X" - but along the way we go through review and find bugs and you do a series of commits like "fix stupid typo in X test", "fix missing file in X test", blah blah - there's no sense keeping all those 'fixup' commits, so we should just squash them down.

But if you want to add an X test, and also add a Y test, and along the way you notice an unrelated bug in Z and want to fix that too - that's three separate commits. :)

As discussed in person - please drop Evolution needles as well as test, and rename _f30 needles to -f30 or (I prefer) -20190128 or so.

Clocks failed - I'm guessing the screen the needle is based on only shows up if the app cannot geolocate and create a default clock, or something. Maybe match on the button bar at the top of the app as that's consistent whichever initial screen appears. Other than that, though, this seems to work fine, so let's go ahead and merge it as it's much better than what's there right now, and you can fix clocks as a follow-up. Thanks!

I have updated the needle target on master branch. Since it was an easy fix, I think that an extra pull request was not necessary.