I get errors in most cases when I try to link my account. Example:
#### URL: https://packager-dashboard.fedoraproject.org/dashboard?users=frantisekz&oidc_token=None #### Error message: TypeError: this is undefined value@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1288948 zi@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1159997 Gi@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1162434 Vi@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1161694 eo@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1164647 n@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1288457 o@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1117766 se@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1119605 #### Stacktrace: value@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1288645 4463/vs/n.callback@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:459334 Lo@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:440363 wu@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:488139 bu@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:487707 yu@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:487243 4463/_l/<@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:499080 _l@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:499595 il@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:492055 x@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:562149 D@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:562682
Note that users=frantisekz in URL. But I was looking at kparal dashboard at that moment, not frantisekz. I looked at frantisekz previously.
users=frantisekz
kparal
frantisekz
Another attempt, this time I get kparal in URL:
#### URL: https://packager-dashboard.fedoraproject.org/dashboard?users=kparal&oidc_token=<token_redacted> #### Error message: TypeError: this is undefined value@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1288948 zi@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1159997 Gi@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1162434 Vi@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1161694 eo@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1164647 n@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1288457 o@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1117766 se@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1119605 #### Stacktrace: value@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1288645 4463/vs/n.callback@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:459334 Lo@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:440363 wu@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:488139 bu@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:487707 yu@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:487243 4463/_l/<@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:499080 _l@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:499595 il@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:492055 x@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:562149 D@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:562682
Sometimes I can just reload the dashboard and the account is linked, even after the error. Sometimes it isn't. Sometimes I click "Link", it reloads, and it's not linked. It's broken.
Metadata Update from @frantisekz: - Issue assigned to lbrabec
@kparal I have removed your oidc_token value from the second log, for sake of security of your profile.
@lbrabec I can reproduce this too, the case when oidc_token is None is something that shouldn't happen (eg. infra or backend problem), but I am getting the second case log of kparal's report where token is passed from the backend just fine and the frontend blows up anyway.
#### URL: https://packager-dashboard.fedoraproject.org/dashboard?users=frantisekz&oidc_token=<token_value> #### Error message: TypeError: Cannot read properties of undefined (reading 'props') at value (https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1288953) at zi (https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1159999) at Gi (https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1162436) at Vi (https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1161696) at eo (https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1164649) at n (https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1288455) at o (https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1117766) at se (https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1119607) #### Stacktrace: Error: TypeError: Cannot read properties of undefined (reading 'props') at value (https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1288953) at zi (https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1159999) at Gi (https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1162436) at Vi (https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1161696) at eo (https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1164649) at n (https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1288455) at o (https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1117766) at se (https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1119607) at n.value (https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1288645) at o.componentDidCatch.n.callback (https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:459334) at Lo (https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:440363) at wu (https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:488139) at bu (https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:487707) at yu (https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:487243) at https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:499080 at _l (https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:499595) at il (https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:492053) at x (https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:562148)
Hey! I'm having this issue too
#### URL: https://packager-dashboard.fedoraproject.org/dashboard?users=abompard&oidc_token=93575685-edited-for-security_reasons #### Error message: TypeError: this is undefined value@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1288948 zi@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1159997 Gi@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1162434 Vi@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1161694 eo@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1164647 n@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1288457 o@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1117766 se@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1119605 #### Stacktrace: value@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1288645 4463/vs/n.callback@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:459334 Lo@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:440363 wu@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:488139 bu@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:487707 yu@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:487243 4463/_l/<@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:499080 _l@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:499595 il@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:492055 x@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:562149 D@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:562682
I have got slightly different error message.
#### URL: https://packager-dashboard.fedoraproject.org/dashboard?users=pemensik&oidc_token=None #### Error message: TypeError: this is undefined value@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1288948 zi@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1159997 Gi@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1162434 Vi@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1161694 eo@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1164647 n@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1288457 o@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1117766 se@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1119605 #### Stacktrace: value@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:1288645 4463/vs/n.callback@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:459334 Lo@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:440363 wu@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:488139 bu@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:487707 yu@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:487243 4463/_l/<@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:499080 _l@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:499595 il@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:492055 x@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:562149 D@https://packager-dashboard.fedoraproject.org/static/js/main.8386eb83.js:2:562682
@pemensik @abompard @kparal We have deployed some improvements in the login process which should(tm) make it more reliable. Can you give it a shot if it works for you?
To slightly elaborate, there may have been more than one issue in the process, we believe it should work fine for all users now (be sure to update the dashboard if you had in open and/or refresh the page), but I'll leave the issue open for more confirmations.
I currently can't link my FAS at all. When I clicked it for the first time, it redirected me to the dashboard home screen (like Logout). The next attempts redirected me back to my dashboard homepage. But FAS is not linked. And there's oidc_token=None in the URL each time.
oidc_token=None
Thanks for testing, huh, what'd worked on Friday went south now (I could reproduce this behavior). Deleting packager-dashboard.fedoraproject.org cookies got it working for me (while leaving oidc_token in the url even after the successful login, @lbrabec ).
What works reliably for me: delete cookies, initiate login.
@lbrabec , can you implement cookies, session deletion on each login/logout attempt? That would mean also the cookies stored from id.fedoraproject.org (chrome lists tem under cookies from the app). Ideally without settings store deletion.
With the recent refactoring, fixing and upgrading Flask-OIDC backend side, this should now be fixed and working fine.
Please, do reopen this one if it's not the case!
Metadata Update from @frantisekz: - Issue status updated to: Closed (was: Open)
Metadata Update from @jskladan: - Custom field story_points adjusted to 1 - Issue assigned to frantisekz (was: lbrabec)
Log in to comment on this ticket.