fedora-reproducible-builds / project

#18 golang packages have invalid changelog entries so $SOURCE_DATE_EPOCH is not set
Closed by zbyszek. Opened by zbyszek.

Closed
Reopen Issue

The report looks like this:

    golang-github-jedisct1-hpke-compact-devel-0.9.0-8.fc41.noarch
        modified-..........T /usr/share/doc/golang-github-jedisct1-hpke-compact-devel
        modified-..........T /usr/share/gocode/src/github.com
        modified-..........T /usr/share/gocode/src/github.com/jedisct1
        modified-..........T /usr/share/gocode/src/github.com/jedisct1/go-hpke-compact
        modified-..........T /usr/share/gocode/src/github.com/jedisct1/go-hpke-compact/.goipath
        modified-..........T /usr/share/licenses/golang-github-jedisct1-hpke-compact-devel

Similar issues appear in other packages.

The mtime of .goipath is not clamped because $SOURCE_DATE_EPOCH is not set:

$ fedpkg srpm
...
error: bad date in %changelog: dim. oct. 03 2021 Robert-André Mauchin <zebob.m@gmail.com> 0.9.0-1
warning: source_date_epoch_from_changelog set but %changelog is missing
$ rpm -qp --changelog golang-github-jedisct1-hpke-compact-devel-0.9.0-7.fc40.noarch.rpm
(nothing)

@eclipseo, comments?

    golang-github-artyom-mtab-devel-0-0.9.20211221gitc69458c.fc41.noarch
        modified-..........T /usr/share/gocode/src/github.com
        modified-..........T /usr/share/gocode/src/github.com/artyom
        modified-..........T /usr/share/gocode/src/github.com/artyom/mtab
        modified-..........T /usr/share/gocode/src/github.com/artyom/mtab/.goipath
        modified-..........T /usr/share/licenses/golang-github-artyom-mtab-devel

    golang-github-gobuffalo-packr-devel-2.8.1-11.fc41.noarch
        removed /usr/share/doc/golang-github-gobuffalo-packr-devel/example/a_example-packr.go
        removed /usr/share/doc/golang-github-gobuffalo-packr-devel/example/foo/a_foo-packr.go
        modified-..........T /usr/share/doc/golang-github-gobuffalo-packr-devel/example
        modified-..........T /usr/share/doc/golang-github-gobuffalo-packr-devel/example/foo

The missing files are a separate issue. But the timestamp could be this issue.

    golang-github-jwt-4-devel-4.2.0-7.fc41.noarch
        modified-..........T /usr/share/doc/golang-github-jwt-4-devel
        modified-..........T /usr/share/gocode/src/github.com
        modified-..........T /usr/share/gocode/src/github.com/golang-jwt
        modified-..........T /usr/share/gocode/src/github.com/golang-jwt/jwt
        modified-..........T /usr/share/gocode/src/github.com/golang-jwt/jwt/v4
        modified-..........T /usr/share/gocode/src/github.com/golang-jwt/jwt/v4/.goipath
        modified-..........T /usr/share/gocode/src/github.com/golang-jwt/jwt/v4/cmd
        modified-..........T /usr/share/gocode/src/github.com/golang-jwt/jwt/v4/cmd/jwt
        modified-..........T /usr/share/gocode/src/github.com/golang-jwt/jwt/v4/request
        modified-..........T /usr/share/gocode/src/github.com/golang-jwt/jwt/v4/test
        modified-..........T /usr/share/licenses/golang-github-jwt-4-devel

golang-github-gobuffalo-packr: different issue

golang-github-jwt-4:
error: bad date in %changelog: jeu. janv. 27 2022 Robert-André Mauchin zebob.m@gmail.com 4.2.0-1
warning: source_date_epoch_from_changelog set but %changelog is missing

golang-github-gobuffalo-packr: different issue

Oh, I think I know. In the rebuild, %check was skipped. I assume the .go file was created in %check.

The issue is caused by a broken personal workflow in the initial package setup. I tried to fix a few packages, and the fix is trivial and actually resolves the issue of a lack of changelog in the package. So I think we should just apply a fix to all affected packages and move on.

I fixed the four cases that were present in last mini mass rebuild:
golang-github-jwt-4
golang-github-jedisct1-hpke-compact
golang-github-artyom-mtab
golang-github-powerman-deepequal

Let's close this here. If the issue pops up in other packages, it's easy to fix.

Metadata Update from @zbyszek:
- Issue status updated to: Closed (was: Open)
Metadata
None

irreproducibility

None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.