Issue #2: Sanity duplicate check - fedora-skribbl-io

fedora-skribbl-io

#2 Sanity duplicate check

Closed Jun 18, 2021 by bcotton. Opened Jun 17, 2021 by computerkid.

@bcotton how hard would it be to upgrade the make file so that it checks for duplicates in the file? It could throw an error, and then someone manually fixes the issue. I think that would be useful, because we've already had one duplicate issue.

bcotton commented Jun 17, 2021

We could do one better, actually. I can update it to automatically remove duplicates when it generates the comma-separated list. I can make it case insensitive easily enough, but catching differences in spaces, etc will be a challenge.

In addition, we may want to require people to add words in alphabetical order. That'll make it easier to catch duplicates. Probably the best way is to do a commit that reorders the file. What do you think?

computerkid commented Jun 17, 2021

I can alphabetize it.

computerkid commented Jun 17, 2021

Okay, done

bcotton commented Jun 18, 2021

Commit f3450cf adds automated duplicate removal (and support for comment lines).

Commit f398f82 adds some comments to the top of the file.

Metadata Update from @bcotton:
- Issue assigned to bcotton

Jun 18, 2021

Metadata Update from @bcotton:
- Issue status updated to: Closed (was: Open)

Jun 18, 2021