fedora-web / websites

#119 coreos-release-note: fix error produced when calculating pkgdiffs
Merged by dustymabe. Opened by abai.
fedora-web/ abai/websites fix-pkg-diff  into  master

Download 119.patch

This error was not found previously since the conditional block was
not hit when calculating pkgdiffs. Essentially the accumulated pkgdiff
is an array of arrays, and the previous code lacks a layer of indexing
to modify the individual pkgdiff info.

In the future, more error checkings need to be added to handle this kind
of situations more gracefully.

Signed-off-by: Allen Bai abai@redhat.com

cc @dustymabe @jlebon

I don't fully understand this code, but I trust you. :)
So LGTM!

In the future we will drop this code to something much simpler.

assuming this works for all current streams (stable, testing, next) this LGTM.

@dustymabe I triple checked this locally to make sure no more surprises..
@jlebon yes, I was thinking this should be a temporary solution when I was writing this because it's too dependent on the structure of the metadata and a lot of corner cases to consider which makes it error prone.

EDIT: typo :)
Edited by abai
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.