39e4e6a
@@ -1,4 +1,4 @@
- FROM fedora:29
+ FROM fedora:latest
WORKDIR /opt/sites/getfedora.org/
Update the version of fedora from 29 to latest to avoid error creating build container
@gursewak,
Could you please share the logs of the error that you are facing with fedora:29? That would help us decide if at all we need to have the latest release or not.
fedora:29
Metadata Update from @t0xic0der: - Request assigned
@t0xic0der: When I run $ podman build -t fedora-websites . without changing it to "latest"
$ podman build -t fedora-websites .
STEP 1/5: FROM fedora:29 Resolved "fedora" as an alias (/etc/containers/registries.conf.d/000-shortnames.conf) Trying to pull registry.fedoraproject.org/fedora:29... Error: error creating build container: initializing source docker://registry.fedoraproject.org/fedora:29: reading manifest 29 in registry.fedoraproject.org/fedora: manifest unknown: manifest unknown
Running on OS: Fedora 34.20210913.1 (Silverblue)
fedora:29 is only available through docker.io (docker.io/library/fedora:29). I'm ok with this changes, but I would rather see it merged on staging branch first, just to make sure everything is fine, before pushing it on prod.
Also, see this PR #184
fedora:29 is only available through docker.io (docker.io/library/fedora:29).
It's also EOL and probably riddled with security issues at this point.
Note that the actual prod version of the website doesn't use this definition because it defines it's own Dockerfile in the ansible repo. I'm not sure why.
This change would just make it easier for developers. I don't think it needs to go to staging first.
Note that the actual prod version of the website doesn't use this definition because it defines it's own Dockerfile in the ansible repo. I'm not sure why. This change would just make it easier for developers. I don't think it needs to go to staging first.
good point. No need to go on staging then.
We should probably update the buildConfig to point to the Dockerfile in this repo instead. It'll be much easier to maintain, and we can be sure that we are using the same build environment for dev/staging/prod. And actually, I think we should just take the Dockefile from this buildConfig to replace the one here. What do you think ?
SGTM
Closing it since the version was updated in https://pagure.io/fedora-web/websites/c/e806572bb4494b856933680ebdc02360ae4f671b?branch=master
Pull-Request has been closed by gursewak
Update the version of fedora from 29 to latest to avoid error creating build container