From f702eb461b70f89a642392bc87f90f6f7fae3866 Mon Sep 17 00:00:00 2001 From: gursewak Date: Oct 21 2021 19:38:19 +0000 Subject: [PATCH 1/2] Fix cards visibility --- diff --git a/sites/static/js/coreos-release-notes.js b/sites/static/js/coreos-release-notes.js index dc0624f..bfd60eb 100644 --- a/sites/static/js/coreos-release-notes.js +++ b/sites/static/js/coreos-release-notes.js @@ -448,9 +448,9 @@ var coreos_release_notes = new Vue({ e.preventDefault(); Object.entries(build.arches).map(pair => { if(pair[1] == e.target.text) - document.getElementById(build.id+pair[1]).style.display = 'inline' + document.getElementById(build.id+pair[1]).hidden = false else - document.getElementById(build.id+pair[1]).style.display = 'none' + document.getElementById(build.id+pair[1]).hidden = true }); document.getElementById(build.id+"Dropdown").text = e.target.text; } @@ -683,12 +683,12 @@ var coreos_release_notes = new Vue({ downgradedPkgsHeading = h('p', { class: "mt-3" }, "Downgraded:"); } let downgradedPkgsElements = h('div', { attrs: { hidden: true } }, [downgradedPkgsHeading, h('ul', {}, downgradedPkgsElementsList)]); - let rightPaneData = h('div', { attrs: {id: build.id.concat(eachArch), style: "display: inline;" }, class: "col-lg-10 border-bottom mb-5 pb-4" }, + let rightPaneData = h('div', { attrs: {id: build.id+eachArch}, class: "col-lg-10 border-bottom mb-5 pb-4" }, [date, importantPkgsElements, pkgSummaryDiv, totalPkgsElements, addedPkgsElements, removedPkgsElements, upgradedPkgsElements, downgradedPkgsElements]); // Hiding the information cards of the unselected architectures if(eachArch!=selectedArch) - rightPaneData.data.attrs.style = "display: none;" + rightPaneData.data.attrs.hidden = true rightPane.push(rightPaneData) }); let row = h('div', { class: "row" }, [leftPane, rightPane]); From 81b2205dca5bc7983b05089f3d2b3b909813822d Mon Sep 17 00:00:00 2001 From: gursewak Date: Oct 21 2021 19:39:32 +0000 Subject: [PATCH 2/2] Check streamData for null to avoid console error --- diff --git a/sites/static/js/coreos-download.js b/sites/static/js/coreos-download.js index 9604338..40fec28 100644 --- a/sites/static/js/coreos-download.js +++ b/sites/static/js/coreos-download.js @@ -652,7 +652,7 @@ var coreos_download_app = new Vue({ searchParams.set('stream', 'stable'); } // switch to specified arch if `arch` parameter is set - if (searchParams.has('arch')) { + if (searchParams.has('arch') && this.streamData) { const architectures = getMember(this.streamData, "architectures"); let architectureList = Object.keys(architectures); // Checking if the value of arch is in the list of arches from streamData