PR#77: coreos-download: add tab view for coreos download page -

fedora-web / websites

#77 coreos-download: add tab view for coreos download page

Merged Dec 18, 2019 by bcotton. Opened Dec 17, 2019 by abai.

fedora-web/ abai/websites coreos-download into master

abai commented Dec 17, 2019

The current view for coreos download page requires users scrolling a
lot in order to view cloud operators download because of the long list of
cloud launchable instances. To improve this, tab view is added.

Related to: https://pagure.io/fedora-websites/issue/964
Signed-off-by: Allen Bai abai@redhat.com

abai commented Dec 17, 2019

cc @rfairley @jlebon @dustymabe
Could you take a quick look to see if this looks reasonable? Thanks :smile:

bcotton commented Dec 17, 2019

LGTM. I'll merge if we don't get any objections.

Metadata Update from @bcotton:
- Request assigned

Dec 17, 2019

Metadata Update from @bcotton:
- Pull-request tagged with: content, design

Dec 17, 2019

rfairley commented Dec 17, 2019

Minor: the three tab inner text strings e.g. "For Cloud Operators" could be made constants (perhaps cloudTabInnerText, defined globally for this file) - and refer to the constant elsewhere (e.g. on https://pagure.io/fork/abai/fedora-web/websites/blob/826f0773a947171fe2d1b32483f6d2724c03c673/f/sites/static/js/coreos-download.js#_253). Not a major issue as it'd be clear the tab doesn't work if one of the inner text string definitions got changed without changing the place it's used - but thinking it'd be cleaner to define it once, if the two definitions are expected to match.

rfairley commented Dec 17, 2019

One minor comment, otherwise LGTM! Ran it locally and the page looks good.

rfairley commented Dec 17, 2019

Screenshots for reference:
https://rfairley.fedorapeople.org/Screenshot_2019-12-17%20Get%20Fedora.png
https://rfairley.fedorapeople.org/Screenshot_2019-12-17%20Get%20Fedora(1).png
https://rfairley.fedorapeople.org/Screenshot_2019-12-17%20Get%20Fedora(2).png

1 new commit added