PR#633: Update the style of start.fedoraproject.org -

fedora-websites

#633 Update the style of start.fedoraproject.org

Merged Apr 11, 2017 by ryanlerch. Opened Jan 26, 2017 by mhsabbagh.

Unknown source master

mhsabbagh commented Jan 26, 2017

I have made the background darker and the header separators are back. Is it good?

mhsabbagh commented Jan 27, 2017

Any comment? The requested changes are made. If something else needs to be changed. I can work on it.

ryanlerch commented Jan 30, 2017

@mhsabbagh if this is a cosmetic change, it would be super useful here too to have a before / after screenshot here on this thread, so we can get a quick look at the changes.

cheers,
ryanlerch

mhsabbagh commented Jan 30, 2017

@ryanlerch Hello.

This is the screenshot for the current page (before): http://i.imgur.com/XdSCGlR.png
This is the screenshot for the page after modification: http://i.imgur.com/coQL1ab.png

mhsabbagh commented Feb 6, 2017

Follow-ups?

ryanlerch commented Apr 11, 2017

@robyduck i like this lighter style. Any objections from your side?

robyduck commented Apr 11, 2017

I don't have a strong opinion about this PR, I'm fine with both. If you like it, and it builds fine without issues, go for it.

Pull-Request has been merged by ryanlerch

Apr 11, 2017