#134 Add sti-typed test jobs
Merged by zuul. Opened by guyinger.
guyinger/fedora-zuul-jobs-config tft-788-sti  into  master

Download 134.patch
no initial comment

Build succeeded.

@tdecacqu @fbo - I copied the same job definition of "rpm-tmt-test" to create the same kind of jobs for sti-typed tests but for some reason it doesn't create these new sti jobs, any idea why?

Edit: it's fixed, thanks @mvadkert !

Build succeeded.

it is quite clear, on line 279 a concatenation of generateSTITestsJobs is missing. Note that # is not a comment, it is a list concatenation ...

perhaps you could add another parameter to this function which is the test_type and then named it more generically getTestingFarmJobVars. Then we could remove getSTIJobVars and getTMTJobVars and only use getTestingFarmJobVars.

rebased onto 317dafb64b3d4bc90124bc8d1a42778ccf24df37

Build succeeded.

@fbo if I go with a generic getTestingFarmJobVars, would it be possible to use only one of the vars? I'd need either "sti" or "fmf", but not both at the same time

Yes as getTestingFarmJobVars is a function you can then pass the required value for the new parameter in generateSTITestsJob and generateTMTTestsJob

, vars = Some (getTestingFarmJobVars branch "sti")
, vars = Some (getTestingFarmJobVars branch "tmt")

Something like:

let getTestingFarmJobVars =
      λ(branch : Branches.Type) 
      λ(ttype : Text) 
        let name =
              merge
                { Rawhide = "Fedora-Rawhide"
                , F33 = "Fedora-33"
                , F34 = "Fedora-34"
                , F35 = "Fedora-35"
                , Epel8 = "Fedora-epel8"
                }
                branch
        in  Zuul.Vars.object
              [ { mapKey = "compose", mapValue = Zuul.Vars.string name }
              , { mapKey = "test_type", mapValue = Zuul.Vars.string ttype }
              ]

rebased onto 9f581fdb0eba500a76791659d64aa534fe83d303

Build succeeded.

rebased onto 4b1ef9b8d4b91387b1112943634decd384999c38

@fbo thanks, done

Build succeeded.

Metadata Update from @fbo:
- Pull-request tagged with: gateit

Build succeeded (gate pipeline).

Pull-Request has been merged by zuul

Metadata