#535 Remove PDC queries from fedpkg
Closed: Fixed 6 months ago by onosek. Opened 9 months ago by lenkaseg.

As part of the PDC retirement initiative [0], all existing PDC queries should be removed and replaced with appropriate calls to the Bodhi API or distgit API.

There are 3 functions in fedpkg using pdc:
get_stream_branches
get release branches
query_pdc

[0] https://fedora-arc.readthedocs.io/en/latest/pdc/index.html


I started to work on this issue, pull request coming soon. (I cannot assign myself unfortunately)
There is one thing I don't understand:
https://pagure.io/fedpkg/blob/master/f/fedpkg/utils.py#_522
- here it seems to be filtering out branches that would match for example f38, f39. Does that mean those cannot be stream_branches?

get_stream_branches classifies branches as:
release branches: rawhide, main, f38, f39, el5, el6, epel7, epel8-playground, epel8-next
stream branches: epel8, anything else

Do not miss that also get_sl_type uses the pdc.

Thanks!
Can you assign me on this issue please?

Metadata Update from @onosek:
- Issue assigned to lenkaseg

9 months ago

I did that. But why did you need it? I don't assign myself to issues I am working on.

Thanks! It's just my habit, it reduces the chance someone else would start working on the same issue and duplicate the work unnecessarily. Also I can see the issues assigned to me in my profile under "My issues" so I don't forget :)

Relevant change that possibly touched the code you are going to look at: https://pagure.io/fedpkg/pull-request/532

Yep, taking it into account

Regarding the get_sl_type, can it be that this might not be needed anymore?
There are currently four SL types in PDC:

{
    "count": 4,
    "next": null,
    "previous": null,
    "results": [
        {
            "id": 1,
            "name": "bug_fixes",
            "description": "Bug fixes"
        },
        {
            "id": 3,
            "name": "rawhide",
            "description": "Rolling rawhide.  Generally, tracks upstream."
        },
        {
            "id": 2,
            "name": "security_fixes",
            "description": "Security fixes"
        },
        {
            "id": 4,
            "name": "stable_api",
            "description": "Will do our best not to break API."
        }
    ]
}

The PR does not solve the get_sl_type. I can make a separate PR for that, probably suggesting to remove it entirely, if that's ok.

Log in to comment on this ticket.

Metadata