#581 fedpkg commit -c duplicating the changelog line multiple times as the commit message
Closed: Fixed by onosek. Opened by adamwill.

[adamw@xps13a bind (rawhide)]$ rpmdev-bumpspec -c "- No change sidetag rebuild to include bind-dyndb-ldap" *.spec
[adamw@xps13a bind (rawhide *)]$ fedpkg commit -c
[rawhide a648f7c] No change sidetag rebuild to include bind-dyndb-ldap
 1 file changed, 4 insertions(+), 1 deletion(-)
[adamw@xps13a bind (rawhide)]$ git show
commit a648f7cc81e2f430a21fff3de0d69077434cb9be (HEAD -> rawhide)
Author: Adam Williamson <awilliam@redhat.com>
Date:   Fri Dec 20 09:29:12 2024 -0800
    No change sidetag rebuild to include bind-dyndb-ldap
    No change sidetag rebuild to include bind-dyndb-ldap
    No change sidetag rebuild to include bind-dyndb-ldap
    No change sidetag rebuild to include bind-dyndb-ldap
    No change sidetag rebuild to include bind-dyndb-ldap
    No change sidetag rebuild to include bind-dyndb-ldap
    No change sidetag rebuild to include bind-dyndb-ldap

That doesn't look right.


I also have this problem on Fedora 41

rfpkg ci -c . seems doesn't have the same problem , in RPMFusion we follow fedpkg , last time we "sync" was more or less in 2021

https://github.com/rpmfusion-infra/rfpkg/commit/fde563d5f13ecd1159e5aee5b0fc803822a7d50b

I tried run rfpkg with --release on fedora branch and errors happens in the same way of fedpkg , so seems the problem is not in fedpkg and can be something in rpkg or even in git repos ...

I guess, the issue comes from rpm.
when commit -c is run, the clog method is executing:
rpm -q --qf '%{CHANGELOGTEXT}\n' --undefine '_changelog_trimtime' --specfile <SPECFILE>
The duplication occurs in Fedora 41, where rpm-4.20 is installed.
On Fedora 40 with rpm-4.19 the behaviour is unchanged.

Commit 7b3f92f6 fixes this issue

Please don't fix this, I am already used to delete the duplicated entries and it will ruin my workflow ๐Ÿ˜‚

Just joking. Really happy to see this fixed ๐ŸŽ‰

we need a new release of rpkg, the commit https://pagure.io/rpkg/c/7b3f92f6 fixes the issue but many people still don' use it

Metadata Update from @onosek:
- Issue set to the milestone: 1.46

Metadata
Related Pull Requests