PR#366: verrel command on master asks Koji first -

fedpkg

#366 verrel command on master asks Koji first

Merged Dec 9, 2019 by onosek. Opened Dec 9, 2019 by onosek.

onosek/fedpkg verrel_on_master into master

onosek commented Dec 9, 2019

fedpkg verrel on master branch could return wrong result in some
cases. Now running order is: asks active Koji session, asks anonymous
Koji session and then if there is still no result, tries to determine
release offline. Fedpkg ability to work offline is still desirable.

JIRA: COMPOSE-3876
Fixes: #357

Signed-off-by: Ondrej Nosek onosek@redhat.com

lsedlar commented Dec 9, 2019

I'm wondering if it makes sense to keep both koji checks. They should return the same answer, and I think the only situation when authenticated query would work but anonymous fail is authentication error. Why not simply always try without authentication?

lsedlar commented Dec 9, 2019

We discussed this offline, and it will save some overhead in case the session exists already.
:thumbsup: from me.

Pull-Request has been merged by onosek

Dec 9, 2019

Metadata

Assignee

None

Tags

No Tags

fedpkg

#366 verrel command on master asks Koji first Merged Dec 9, 2019 by onosek. Opened Dec 9, 2019 by onosek. onosek/fedpkg verrel_on_master into master

Metadata

#366 verrel command on master asks Koji first

Merged Dec 9, 2019 by onosek. Opened Dec 9, 2019 by onosek.

onosek/fedpkg verrel_on_master into master