#430 Changes for default branches on different namespaces
Merged by onosek. Opened by mohanboddu.
mohanboddu/fedpkg default_branches  into  master

Download 430.patch

Fix for #428

Signed-off-by: Mohan Boddu mboddu@bhujji.com

Also removing all the unnecessary references to master as we moved away from master.

rebased onto a54e97156085d873ffe9761ef3afa557fd646b29

do we need this elif branch with 'tests' when there is separated method request_tests_repo?

we lost "master" but we gained "stable". Does it make sense place it here (and/or other places)?

hmm, this was probably an invalid comment.

I would prefer just pass branch='rawhide' and inside of "_request_repo" have (if ns=="flatpak": branch = "stable"). It would look easier.

1 new commit added

  • Cleaner approach of default branch in new repo request

I updated PR as per the requests.

we lost "master" but we gained "stable". Does it make sense place it here (and/or other places)?

hmm, this was probably an invalid comment.

Yeah, all the master references are related to rpms namespace only.

FYI, it doesn't handle the case of requesting a default branch of their own for modules as it just requests rawhide branch. But it will serve the purposes that is needed for now.

Commit f9530a42 fixes this pull-request

Pull-Request has been merged by onosek

Thanks @mohanboddu. I just modified the commit message, squashed commits and repaired unittests.

I suppose that fedpkg patch with this change is expected now.

@mohanboddu There are patches in Bodhi with this change. So far except f34, where I am waiting for stable rpkg. Please confirm that it is OK. I don't want to release something early again :-).

Metadata