PR#592: Check that auth tokens aren’t written to world-readable files - fedpkg

Peter Oliver • 18 days ago

6b7a842

test/test_cli.py

file modified

+19

		`@@ -2499,3 +2499,22 @@`
		`except rpkgError as error:`
		`expected_error = "ERROR: Token is not properly formatted."`
		`self.assertEqual(error, expected_error)`
		`+`
		`+ @patch('getpass.getpass')`
		`+ def test_token_readable_only_by_user(self, mock_getpass):`
		`+`
		`+ TOKEN = "".join(['X' for _ in range(64)])`
		`+`
		`+ cli_cmd = ['fedpkg', 'set-pagure-token']`
		`+ cli = self.get_cli(cli_cmd)`
		`+ mock_getpass.return_value = TOKEN`
		`+`
		`+ old_umask = os.umask(0)`
		`+ cli.set_pagure_token()`
		`+ os.umask(old_umask)`
		`+`
		`+ PATH = os.path.join(os.path.expanduser('~'),`
		`+ '.config',`
		`+ 'rpkg',`
		`+ '{0}.conf'.format(cli.name))`
		`+ self.assertEqual(os.stat(PATH).st_mode & 0o077, 0)`