fm-orchestrator

#706 Submitting module builds sometimes crashes the client
Closed Opened by psabata.

Closed
Reopen Issue

This happens every once in a while:

% mbs-build submit -w
Traceback (most recent call last):
  File "/usr/bin/mbs-build", line 522, in <module>
    main()
  File "/usr/bin/mbs-build", line 494, in main
    args.idprovider, args.pyrpkg_client, args.verify, args.optional)
  File "/usr/bin/mbs-build", line 277, in submit_module_build
    data = resp.json()
  File "/usr/lib/python2.7/site-packages/requests/models.py", line 866, in json
    return complexjson.loads(self.text, **kwargs)
  File "/usr/lib64/python2.7/site-packages/simplejson/__init__.py", line 516, in loads
    return _default_decoder.decode(s)
  File "/usr/lib64/python2.7/site-packages/simplejson/decoder.py", line 374, in decode
    obj, end = self.raw_decode(s)
  File "/usr/lib64/python2.7/site-packages/simplejson/decoder.py", line 404, in raw_decode
    return self.scan_once(s, idx=_w(s, idx).end())
simplejson.scanner.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

I suspect it's HTTP 500 but still, could we catch that exception and inform the user in some nicer way, perhaps even printing the HTTP response? It might help with debugging the problem, too.

Sometimes this happens very early and MBS doesn't even register the submission. Sometimes it does but it's then unclear whether it's stuck or just checking refs -- when you check the progress, you see:

% mbs-build overview
  ID  State    Submitted             Components    Owner    Module
----  -------  --------------------  ------------  -------  ------------------------------
 980  init     2017-09-20T16:54:07Z  0/0           psabata  platform-master-20170920165346

Which is not super helpful. Perhaps you could also marked verified components and the Components comlumn could show how many out of how many have been verified? Of course this would require additional states...

Maybe it actually submits it fine but then crashes when it tries to watch the build? That could also be, even though at that point the module should be in wait at least.

I'll close this ticket since mbs-build is deprecated and fedpkg should be used instead and should handle this situation.

Metadata Update from @mprahl:
- Issue status updated to: Closed (was: Open)

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/mbs/issues/706

Please continue any further discussion there.
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.