Issue #951: Propose/describe a convenient way of testing within the mbs/test docker img - fm-orchestrator

fm-orchestrator

#951 Propose/describe a convenient way of testing within the mbs/test docker img

Closed: Fixed 6 years ago Opened 6 years ago by fivaldi.

The testing is inconvenient and not described properly anywhere.
Adding --rm=false to docker build seems to be a workaround.

See also current TODO in Dockerfile-tests:

# TODO: Consider making this a volume instead
COPY . .

mprahl commented 6 years ago

How is it "inconvenient and not described properly"?

fivaldi commented 6 years ago

@mprahl Editing files and re-running tests is not really easy as the files are copied in one build step to the docker image. I tried mounting a volume to the container, but there were other manual tasks necessary. E.g.: git clean to get rid of *.pyc linked to the host libs. There may be other manual steps involved in the process of repeated testing. It is also time-demanding.

The docker build --rm=false ... seems to be a reasonable workaround, at least.

Metadata Update from @mprahl:
- Issue assigned to mprahl

6 years ago

mprahl commented 6 years ago

@fivaldi could you review https://pagure.io/fm-orchestrator/pull-request/953?

fivaldi commented 6 years ago

PR#953 fixes this issue. Thanks again!

Metadata Update from @fivaldi:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

6 years ago