From 0019b0b555d4dd87d8dc4a01a0d4962f5b1632b7 Mon Sep 17 00:00:00 2001 From: Tomas Kopecek Date: Jun 21 2021 11:56:06 +0000 Subject: PR#2900: kojiweb - Fix getting tag ID for buildMaven taskinfo page. Merges #2900 https://pagure.io/koji/pull-request/2900 Fixes: #2899 https://pagure.io/koji/issue/2899 buildMaven task page results in a TypeError --- diff --git a/www/kojiweb/index.py b/www/kojiweb/index.py index bf46222..c33d173 100644 --- a/www/kojiweb/index.py +++ b/www/kojiweb/index.py @@ -685,10 +685,13 @@ def taskinfo(environ, taskID): if task['method'] in ('buildArch', 'buildMaven', 'buildSRPMFromSCM'): if len(params) > 1: + tag_id = params[1] + if isinstance(tag_id, dict): + tag_id = tag_id.get('id') try: - values['buildTag'] = server.getTag(params[1], strict=True) + values['buildTag'] = server.getTag(tag_id, strict=True) except koji.GenericError: - values['buildTag'] = {'name': "%d (deleted)" % params[1], 'id': None} + values['buildTag'] = {'name': "%d (deleted)" % tag_id, 'id': None} elif task['method'] == 'tagBuild': destTag = server.getTag(params[0]) build = server.getBuild(params[1])