From 09fee79b3dda68471a6890bdb47e2d77d24f33b8 Mon Sep 17 00:00:00 2001 From: Mike McLean Date: Jan 05 2024 10:00:57 +0000 Subject: block draft builds that can't be promoted --- diff --git a/kojihub/kojihub.py b/kojihub/kojihub.py index 36312d7..62e6b61 100644 --- a/kojihub/kojihub.py +++ b/kojihub/kojihub.py @@ -6116,12 +6116,10 @@ def new_build(data, strict=False): data.setdefault('volume_id', 0) data.setdefault('draft', False) - old_binfo = None - if not data.get('draft'): - # check for existing build - old_binfo = get_build(data) + # check for existing build + old_binfo = get_build(data) if old_binfo: - if strict: + if strict or data['draft']: raise koji.GenericError(f'Existing build found: {old_binfo}') recycle_build(old_binfo, data) # Raises exception if there is a problem