From a2d9d756feae46a31899a290d8ab1c15e72c3837 Mon Sep 17 00:00:00 2001 From: Mike McLean Date: Oct 30 2017 16:09:04 +0000 Subject: drop stale comment and avoid bare except in safe_rmtree --- diff --git a/koji/tasks.py b/koji/tasks.py index 88604c7..e5824b1 100644 --- a/koji/tasks.py +++ b/koji/tasks.py @@ -67,8 +67,6 @@ def umount_all(topdir): def safe_rmtree(path, unmount=False, strict=True): logger = logging.getLogger("koji.build") - #safe remove: with -xdev the find cmd will not cross filesystems - # (though it will cross bind mounts from the same filesystem) if unmount: umount_all(path) if os.path.isfile(path) or os.path.islink(path): @@ -88,7 +86,7 @@ def safe_rmtree(path, unmount=False, strict=True): logger.debug('Scrubbing files in %s' % path) try: koji.util.rmtree(path) - except: + except Exception: logger.warn('file removal failed for %s' % path) if strict: raise