From b0ef16f29313dc816ad8f303db50d53403269014 Mon Sep 17 00:00:00 2001 From: Tomas Kopecek Date: Apr 08 2020 10:55:33 +0000 Subject: rebase fixes --- diff --git a/hub/kojihub.py b/hub/kojihub.py index bdc435d..5932415 100644 --- a/hub/kojihub.py +++ b/hub/kojihub.py @@ -991,9 +991,7 @@ def _direct_pkglist_add(taginfo, pkginfo, owner, block, extra_arches, force, if policy: context.session.assertLogin() policy_data = {'tag': tag_id, 'action': action, 'package': pkginfo, 'force': force} - # don't check policy for admins using force - if not (force and context.session.hasPerm('admin')): - assert_policy('package_list', policy_data) + assert_policy('package_list', policy_data, force=force) if not pkg: pkg = lookup_package(pkginfo, create=True) # validate arches before running callbacks diff --git a/tests/test_hub/test_pkglist.py b/tests/test_hub/test_pkglist.py index 8c8b18e..f9f6c2a 100644 --- a/tests/test_hub/test_pkglist.py +++ b/tests/test_hub/test_pkglist.py @@ -73,7 +73,7 @@ class TestPkglistBlock(unittest.TestCase): get_tag.assert_called_once_with('tag', strict=True) lookup_package.assert_called_once_with('pkg', strict=True) assert_policy.assert_called_once_with('package_list', {'tag': tag['id'], - 'action': 'unblock', 'package': pkg['id'], 'force': False, 'extra': {}}, force=False) + 'action': 'unblock', 'package': pkg['id'], 'force': False}, force=False) self.assertEqual(readPackageList.call_count, 2) readPackageList.assert_has_calls([ mock.call(tag['id'], pkgID=pkg['id'], inherit=True), @@ -109,7 +109,7 @@ class TestPkglistBlock(unittest.TestCase): get_tag.assert_called_once_with('tag', strict=True) lookup_package.assert_called_once_with('pkg', strict=True) assert_policy.assert_called_once_with('package_list', {'tag': tag_id, - 'action': 'unblock', 'package': pkg_id, 'force': False, 'extra': {}}, force=False) + 'action': 'unblock', 'package': pkg_id, 'force': False}, force=False) readPackageList.assert_called_once_with(tag_id, pkgID=pkg_id, inherit=True) _pkglist_add.assert_called_once_with(tag_id, pkg_id, owner_id, False, '') _pkglist_remove.assert_not_called() @@ -133,7 +133,7 @@ class TestPkglistBlock(unittest.TestCase): get_tag.assert_called_once_with('tag', strict=True) lookup_package.assert_called_once_with('pkg', strict=True) assert_policy.assert_called_once_with('package_list', {'tag': tag_id, - 'action': 'unblock', 'package': pkg_id, 'force': False, 'extra': {}}, force=False) + 'action': 'unblock', 'package': pkg_id, 'force': False}, force=False) readPackageList.assert_called_once_with(tag_id, pkgID=pkg_id, inherit=True) _pkglist_add.assert_not_called() _pkglist_remove.assert_not_called() @@ -162,7 +162,7 @@ class TestPkglistBlock(unittest.TestCase): get_tag.assert_called_once_with('tag', strict=True) lookup_package.assert_called_once_with('pkg', strict=True) assert_policy.assert_called_once_with('package_list', {'tag': tag_id, - 'action': 'unblock', 'package': pkg_id, 'force': False, 'extra': {}}, force=False) + 'action': 'unblock', 'package': pkg_id, 'force': False}, force=False) readPackageList.assert_called_once_with(tag_id, pkgID=pkg_id, inherit=True) _pkglist_add.assert_not_called() _pkglist_remove.assert_not_called() @@ -224,7 +224,7 @@ class TestPkglistBlock(unittest.TestCase): mock.call(112233), ]) assert_policy.assert_called_once_with('package_list', {'tag': tag['id'], - 'action': 'add', 'package': pkg['name'], 'force': False, 'extra': {}}, force=False) + 'action': 'add', 'package': pkg['name'], 'force': False}, force=False) self.assertEqual(self.run_callbacks.call_count, 2) self.run_callbacks.assert_has_calls([ mock.call('prePackageListChange', action='add', tag=tag, @@ -341,7 +341,7 @@ class TestPkglistBlock(unittest.TestCase): mock.call(112233), ]) assert_policy.assert_called_once_with('package_list', {'tag': tag['id'], - 'action': 'add', 'package': pkg['name'], 'force': False, 'extra': {}}, force=False) + 'action': 'add', 'package': pkg['name'], 'force': False}, force=False) self.assertEqual(self.run_callbacks.call_count, 2) self.run_callbacks.assert_has_calls([ mock.call('prePackageListChange', action='add', tag=tag, @@ -398,7 +398,7 @@ class TestPkglistBlock(unittest.TestCase): mock.call(112233), ]) assert_policy.assert_called_once_with('package_list', {'tag': tag['id'], - 'action': 'add', 'package': pkg['name'], 'force': False, 'extra': {}}, force=False) + 'action': 'add', 'package': pkg['name'], 'force': False}, force=False) self.run_callbacks.assert_called_once_with( 'prePackageListChange', action='add', tag=tag, package=pkg, owner=user['id'], block=block,